From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C06AC433F5 for ; Wed, 6 Apr 2022 02:53:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1445008AbiDFCuA (ORCPT ); Tue, 5 Apr 2022 22:50:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1586675AbiDFABy (ORCPT ); Tue, 5 Apr 2022 20:01:54 -0400 Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46E5DD1CE0 for ; Tue, 5 Apr 2022 15:29:19 -0700 (PDT) Received: by mail-pf1-x42f.google.com with SMTP id y10so758084pfa.7 for ; Tue, 05 Apr 2022 15:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=zrf+gH1Sy82K5gg/a5Dlt8LashIXeZ1Mo8cMFm2VVvg=; b=XUjZIKj8jqoCKPQBxoRD0oT6yLRcHuhC4Wr6StBjL6TZo37AaEt0Nlk4eplWBVAlKQ qCQ6srli5Ee5b3r5s1m496WDbfXWPM4cw3Fxd7VSYVx6qzYivDrsSDFwk+yDlXycVzOS yy5U6llkan+PkDFlrLxWKGJK6FB8i9TQl9rMnkmNFMUpWmQqV2Ko7nPFy2OglfbScM4h 4cIKaDlPFaFF9jTcaBv3Hjx8XlJDBDas+p0bTgQSRNpJYzm8jKmzE9LDausDUnekLQYg tafK8hE11+8CsdOw83m3Gg8IpcsyeSr9J/Q11L51e+dqrfTMprNZ37TYGWPet0tH7y4R GjiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zrf+gH1Sy82K5gg/a5Dlt8LashIXeZ1Mo8cMFm2VVvg=; b=B+BdWQxnsfna/nY8j8VRczaLZGbrGbEQYkSMx9QcRc4QyLnj8pS8YjW2hYg/MZzVfs BaisH3/kiR3+JYWRYw4zZP9TtftuhnfekzswNmSCLjXgB/xckN0b6pBpM90HGCGLvN0+ RCqFC47tfMSHDpjeknoxCkDfjlXmCjND1x6wa7/yGl+l14XQEFzUiS6LNbSDq44FaoN5 BkMh7/4/ilUY0S1UDUZPreqyVTs1+dtnIGhmIvjijtimBAMK/MyYBcuSvBbMUeew69Jh bkc/FnsCWsJRy0vcOHD3G7gLCD+Q10M75Vy8Vrh7qGPjZy9eSqIwrwHKOoejty7DtEVP UexA== X-Gm-Message-State: AOAM532jc+kH+jeRcddY+rSavBFkOLqw13gx8pAMZJKaggUJ8Ns3npsN x3GL9v/yJGESknKQ74U2RgmoNA== X-Google-Smtp-Source: ABdhPJx6IY9EGt0b0qbYftl89h0mvbMZqBI+7Kb7FvHypla16ubEn6sqa6u3cC3uxui+wwmj1RXOxg== X-Received: by 2002:a63:f507:0:b0:380:c32c:d696 with SMTP id w7-20020a63f507000000b00380c32cd696mr4581890pgh.226.1649197758365; Tue, 05 Apr 2022 15:29:18 -0700 (PDT) Received: from google.com (254.80.82.34.bc.googleusercontent.com. [34.82.80.254]) by smtp.gmail.com with ESMTPSA id x67-20020a623146000000b004fdf02851e5sm10182068pfx.220.2022.04.05.15.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Apr 2022 15:29:17 -0700 (PDT) Date: Tue, 5 Apr 2022 22:29:14 +0000 From: David Matlack To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Xu , Sean Christopherson , Jim Mattson , David Dunn , Jing Zhang , Junaid Shahid Subject: Re: [PATCH v3 05/11] KVM: selftests: Improve error message in vm_phy_pages_alloc Message-ID: References: <20220330174621.1567317-1-bgardon@google.com> <20220330174621.1567317-6-bgardon@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220330174621.1567317-6-bgardon@google.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 30, 2022 at 10:46:15AM -0700, Ben Gardon wrote: > Make an error message in vm_phy_pages_alloc more specific, and log the vm_phy_pages_alloc() > number of pages requested in the allocation. > > Signed-off-by: Ben Gardon > --- > tools/testing/selftests/kvm/lib/kvm_util.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/lib/kvm_util.c b/tools/testing/selftests/kvm/lib/kvm_util.c > index 09742a787546..9d72d1bb34fa 100644 > --- a/tools/testing/selftests/kvm/lib/kvm_util.c > +++ b/tools/testing/selftests/kvm/lib/kvm_util.c > @@ -2408,9 +2408,10 @@ vm_paddr_t vm_phy_pages_alloc(struct kvm_vm *vm, size_t num, > } while (pg && pg != base + num); > > if (pg == 0) { > - fprintf(stderr, "No guest physical page available, " > + fprintf(stderr, > + "Unable to find %ld contiguous guest physical pages. " > "paddr_min: 0x%lx page_size: 0x%x memslot: %u\n", > - paddr_min, vm->page_size, memslot); > + num, paddr_min, vm->page_size, memslot); > fputs("---- vm dump ----\n", stderr); > vm_dump(stderr, vm, 2); > abort(); > -- > 2.35.1.1021.g381101b075-goog >