Re: [PATCH] s390: vfio-ap: Remove the superfluous MODULE_DEVICE_TABLE declaration

Heiko Carstens
2022-04-18T17:01:14Z

On Mon, Apr 18, 2022 at 10:23:38AM -0400, Tony Krowiak wrote:
> Reviewed-by: Tony Krowiak <akrowiak@linux.ibm.com>
>
> On 4/13/22 5:44 AM, Thomas Huth wrote:
> > The vfio_ap module tries to register for the vfio_ap bus - but that's
> > the interface that it provides itself, so this does not make much sense,
> > thus let's simply drop this statement now.
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > See also my previous patch to register it for the "ap" bus instead:
> > https://lore.kernel.org/linux-s390/20211201141110.94636-1-thuth@redhat.com/
> > ... but since it has been decided to not auto-load the module uncondi-
> > tionally, I'd like to suggest to rather drop this line now instead.
> >
> > drivers/s390/crypto/vfio_ap_drv.c | 2 --
> > 1 file changed, 2 deletions(-)

...

Applied, thanks.