From: Bob Tracy <rct@frus.com>
To: debian-alpha@lists.debian.org
Cc: Michael Cree <mcree@orcon.net.nz>,
linux-alpha@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: 5.17.0 boot issue on Miata
Date: Mon, 18 Apr 2022 23:53:50 -0500 [thread overview]
Message-ID: <Yl5AXvU+cBH5ex4K@gherkin.frus.com> (raw)
In-Reply-To: <YlAyZdZ6afL58Ege@gherkin.frus.com>
(Adding linux-scsi and linux-kernel, now that bisection is complete.)
On Wed, Apr 06, 2022 at 05:44:01PM -0500, Bob Tracy wrote:
> v5.17-rc2 ok. v5.17-rc3 I get the disk sector errors and hang that I
> reported in the first message in this thread.
This is on an Alpha Miata platform (PWS 433au) with QLogic ISP1020 controller.
Here's the implicated commit:
edb854a3680bacc9ef9b91ec0c5ff6105886f6f3 is the first bad commit
commit edb854a3680bacc9ef9b91ec0c5ff6105886f6f3
Author: Ming Lei <ming.lei@redhat.com>
Date: Thu Jan 27 23:37:33 2022 +0800
scsi: core: Reallocate device's budget map on queue depth change
We currently use ->cmd_per_lun as initial queue depth for setting up the
budget_map. Martin Wilck reported that it is common for the queue_depth to
be subsequently updated in slave_configure() based on detected hardware
characteristics.
As a result, for some drivers, the static host template settings for
cmd_per_lun and can_queue won't actually get used in practice. And if the
default values are used to allocate the budget_map, memory may be consumed
unnecessarily.
Fix the issue by reallocating the budget_map after ->slave_configure()
returns. At that time the device queue_depth should accurately reflect what
the hardware needs.
Link: https://lore.kernel.org/r/20220127153733.409132-1-ming.lei@redhat.com
Cc: Bart Van Assche <bvanassche@acm.org>
Reported-by: Martin Wilck <martin.wilck@suse.com>
Suggested-by: Martin Wilck <martin.wilck@suse.com>
Tested-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Martin Wilck <mwilck@suse.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_scan.c | 55 +++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 50 insertions(+), 5 deletions(-)
Respectfully,
--Bob
next parent reply other threads:[~2022-04-19 5:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Yj0u150JJpsb9nj4@gherkin.frus.com>
[not found] ` <20220326222157.GA13650@tower>
[not found] ` <YkuejknyPDJoQEDC@gherkin.frus.com>
[not found] ` <20220405050125.GA25969@tower>
[not found] ` <YkxKRElYUhMgOOCN@gherkin.frus.com>
[not found] ` <10d61d8f-edfc-fc39-0936-233692464dbd@gmx.de>
[not found] ` <Yk4XsdHvjrLqN1LR@gherkin.frus.com>
[not found] ` <YlAyZdZ6afL58Ege@gherkin.frus.com>
2022-04-19 4:53 ` Bob Tracy [this message]
2022-04-25 9:26 ` 5.17.0 boot issue on Miata John Garry
2022-05-03 15:50 ` Bob Tracy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl5AXvU+cBH5ex4K@gherkin.frus.com \
--to=rct@frus.com \
--cc=debian-alpha@lists.debian.org \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mcree@orcon.net.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox