From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B989C433F5 for ; Tue, 19 Apr 2022 07:40:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349494AbiDSHnT (ORCPT ); Tue, 19 Apr 2022 03:43:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34412 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349532AbiDSHmp (ORCPT ); Tue, 19 Apr 2022 03:42:45 -0400 Received: from mail.skyhub.de (mail.skyhub.de [5.9.137.197]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5A4CBF48; Tue, 19 Apr 2022 00:40:02 -0700 (PDT) Received: from zn.tnic (p200300ea971b58fe329c23fffea6a903.dip0.t-ipconnect.de [IPv6:2003:ea:971b:58fe:329c:23ff:fea6:a903]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 3E3211EC0535; Tue, 19 Apr 2022 09:39:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1650353997; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=rQXek4tqcEArLSkS/IUTo6V5mstAiO1dFqlCDSGiQXE=; b=hB2N9XJz7rFgUpYjr8iew/p5X3tqixuyQXbHsnUa7Ps/tIFU+cYFV9gIQwab/D4QwHZf/H 8wt/r8C0yCABkfagI8tZ95iuLpwBKqQTAgt1CUoaRbu9O2ZuQTlPgCIT7BKHSVLbgNHjjm qi4O8T8hd6Z6VoLibUC771NQsvZrT2w= Date: Tue, 19 Apr 2022 09:39:53 +0200 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: "Kirill A. Shutemov" , Andy Lutomirski , Sean Christopherson , Andrew Morton , Joerg Roedel , Ard Biesheuvel , Andi Kleen , Kuppuswamy Sathyanarayanan , David Rientjes , Vlastimil Babka , Tom Lendacky , Thomas Gleixner , Peter Zijlstra , Paolo Bonzini , Ingo Molnar , Varad Gautam , Dario Faggioli , Dave Hansen , Brijesh Singh , Mike Rapoport , David Hildenbrand , x86@kernel.org, linux-mm@kvack.org, linux-coco@lists.linux.dev, linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv4 3/8] efi/x86: Implement support for unaccepted memory Message-ID: References: <20220405234343.74045-1-kirill.shutemov@linux.intel.com> <20220405234343.74045-4-kirill.shutemov@linux.intel.com> <20220418155545.a567xnxa6elglapl@box.shutemov.name> <20220418202431.whvql4w57c7l5vpw@box.shutemov.name> <20220418235015.mnujtlmmlyin7y6m@box.shutemov.name> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220418235015.mnujtlmmlyin7y6m@box.shutemov.name> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 19, 2022 at 02:50:15AM +0300, Kirill A. Shutemov wrote: > I find it strange that you go after which has limited > exposure while and are there already. Funny you should mention that: https://lore.kernel.org/r/YlCKWhMJEMUgJmjF@zn.tnic I *have* been working towards that but it's a losing whack-a-mole game when you and others keep adding new stuff. So no, we won't take a pile of changes and let the maintainer clean it up afterwards. > What do you want me to do here? I think the stuff coming from the linux/ namespace you can simply copy into a header in compressed/, like I've done with efi.h. > // The asm/ stuff can be put into a shared/ namespace header like the io stuff you did. > As 1 bit represents 2M, not all chunks can be represented in the bitmap > and they have to be accepted. But the *goal* is to record unaccepted > memory into bitmap. Some accepting is a side effect. > > The early_accept_memory() name is just wrong. Ok, how about process_unaccepted_memory(). It should be generic enough. > Okay, I will do as you want, but I really hate it. I find it really weird that you feel so strongly about it. If I would have been asked to do it, I would've done it without even considering it. But ok, since you feel so strongly about it, I've asked what the other maintainers think. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette