From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: airlied@linux.ie, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, jagan@amarulasolutions.com,
linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
thomas.petazzoni@bootlin.com, tzimmermann@suse.de
Subject: Re: [PATCH v3] drm: of: Properly try all possible cases for bridge/panel detection
Date: Tue, 19 Apr 2022 11:56:50 +0200 [thread overview]
Message-ID: <Yl6HYke4dJsrq9jj@aptenodytes> (raw)
In-Reply-To: <20220416222141.72321-1-paul@crapouillou.net>
[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]
Hi Paul,
On Sat 16 Apr 22, 23:21, Paul Cercueil wrote:
> Hi Paul,
>
> This patch breaks the ingenic-drm driver.
>
> It calls drm_of_find_panel_or_bridge(np, 0, i, ...) starting for i=0, until
> -ENODEV is returned, which does not happen anymore.
>
> The idea is to probe all the connected panels/bridges, should it be done
> differently now?
I've sent out a different patch which restores -ENODEV at:
https://patchwork.freedesktop.org/patch/481135/
Feel free to try it and reply with tested-by/reviewed-by there.
I've also made a proposal in the thread to skip the "child node" mechanism
as soon as an of graph is present, which would allow covering more legit
cases with -ENODEV (the patch linked above doesn't cover all cases that
need -ENODEV).
Ideally we'd like to remove the child node mechanism entirely, but it may
already be part of a device-tree binding spec.
Cheers,
Paul
--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2022-04-19 9:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-29 13:27 [PATCH v3] drm: of: Properly try all possible cases for bridge/panel detection Paul Kocialkowski
2022-03-30 8:25 ` (subset) " Maxime Ripard
2022-04-01 3:16 ` Bjorn Andersson
2022-04-01 7:44 ` Paul Kocialkowski
2022-04-03 3:38 ` Bjorn Andersson
2022-04-05 17:00 ` Thierry Reding
2022-04-06 8:30 ` Paul Kocialkowski
2022-04-20 20:51 ` Rob Clark
2022-04-05 21:21 ` Linus Walleij
2022-04-16 22:21 ` Paul Cercueil
2022-04-19 9:56 ` Paul Kocialkowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yl6HYke4dJsrq9jj@aptenodytes \
--to=paul.kocialkowski@bootlin.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=paul@crapouillou.net \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox