From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-serial@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org,
Gilles Buloz <gilles.buloz@kontron.com>,
Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v2 2/3] tty: Add lookahead param to receive_buf
Date: Fri, 8 Apr 2022 14:58:52 +0300 [thread overview]
Message-ID: <YlAjfAab+Oh3HcCR@smile.fi.intel.com> (raw)
In-Reply-To: <20220408113954.9749-3-ilpo.jarvinen@linux.intel.com>
On Fri, Apr 08, 2022 at 02:39:53PM +0300, Ilpo Järvinen wrote:
> After lookahead for XON/XOFF characters is added by the next
> patch, the receive side needs to ensure the flow-control
> actions are not retaken later on when those same characters
> get read by TTY.
>
> Thus, pass lookahead count to receive_buf and skip
> flow-control character actions if already taken for the
> character in question. Lookahead count will become live after
> the next patch.
...
> + if (c == STOP_CHAR(tty)) {
> + if (!lookahead_done)
But now it can be as below
if (c == STOP_CHAR(tty) && !lookahead_done)
> + stop_tty(tty);
> + } else if ((c == START_CHAR(tty) && !lookahead_done) ||
> (tty->flow.stopped && !tty->flow.tco_stopped && I_IXANY(tty) &&
> c != INTR_CHAR(tty) && c != QUIT_CHAR(tty) &&
> c != SUSP_CHAR(tty))) {
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-08 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 11:39 [PATCH v2 0/3] tty/serial: Process XON/XOFF robustly Ilpo Järvinen
2022-04-08 11:39 ` [PATCH v2 1/3] tty: Add functions for handling flow control chars Ilpo Järvinen
2022-04-08 12:01 ` Andy Shevchenko
2022-04-08 12:20 ` Ilpo Järvinen
2022-04-08 12:45 ` Andy Shevchenko
2022-04-08 11:39 ` [PATCH v2 2/3] tty: Add lookahead param to receive_buf Ilpo Järvinen
2022-04-08 11:58 ` Andy Shevchenko [this message]
2022-04-08 12:34 ` Ilpo Järvinen
2022-04-08 12:48 ` Ilpo Järvinen
2022-04-08 12:49 ` Andy Shevchenko
2022-04-08 14:17 ` Ilpo Järvinen
2022-04-08 11:39 ` [PATCH v2 3/3] tty: Implement lookahead to process XON/XOFF timely Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlAjfAab+Oh3HcCR@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=gilles.buloz@kontron.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox