From: Sam Ravnborg <sam@ravnborg.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
sparclinux@vger.kernel.org
Subject: Re: [PATCH] sparc: cacheflush_32.h needs <linux/mm.h>
Date: Sat, 9 Apr 2022 09:46:40 +0200 [thread overview]
Message-ID: <YlE54Cs0mi0WDPo7@ravnborg.org> (raw)
In-Reply-To: <20220409060215.19890-1-rdunlap@infradead.org>
Hi Randy,
On Fri, Apr 08, 2022 at 11:02:15PM -0700, Randy Dunlap wrote:
> Add <linux/mm.h> to cacheflush_32.h just as in cacheflush_64.h.
Just add a forward declaration like this to fix it:
struct page;
No need to pull in a header file when a forward is enough.
Maybe we could simplify sparc64 in a similar way, but that is another
patch and it may require extra work in other files anyway.
Sam
next prev parent reply other threads:[~2022-04-09 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-09 6:02 [PATCH] sparc: cacheflush_32.h needs <linux/mm.h> Randy Dunlap
2022-04-09 7:46 ` Sam Ravnborg [this message]
2022-04-09 15:11 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlE54Cs0mi0WDPo7@ravnborg.org \
--to=sam@ravnborg.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=rdunlap@infradead.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox