From: Vinod Koul <vkoul@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] clk: qcom: add sc8280xp GCC driver
Date: Tue, 12 Apr 2022 00:01:35 +0530 [thread overview]
Message-ID: <YlR0B8N443IQZFEN@matsya> (raw)
In-Reply-To: <20220408224321.627126-2-bjorn.andersson@linaro.org>
On 08-04-22, 15:43, Bjorn Andersson wrote:
> +static struct clk_branch gcc_aggre_ufs_card_axi_hw_ctl_clk = {
> + .halt_reg = 0x750cc,
> + .halt_check = BRANCH_HALT_VOTED,
> + .hwcg_reg = 0x750cc,
> + .hwcg_bit = 1,
> + .clkr = {
> + .enable_reg = 0x750cc,
> + .enable_mask = BIT(1),
> + .hw.init = &(struct clk_init_data){
> + .name = "gcc_aggre_ufs_card_axi_hw_ctl_clk",
> + .parent_hws = (const struct clk_hw*[]){
> + &gcc_ufs_card_axi_clk_src.clkr.hw,
> + },
> + .num_parents = 1,
> + .flags = CLK_SET_RATE_PARENT,
> + .ops = &clk_branch2_ops, /* XXX: clk_branch2_hw_ctl_ops */
I think comment should be removed (couple of them here)
> +static struct clk_branch gcc_gpu_memnoc_gfx_clk = {
> + .halt_reg = 0x71010,
> + .halt_check = BRANCH_HALT_VOTED,
> + .hwcg_reg = 0x71010,
> + .hwcg_bit = 1,
> + .clkr = {
> + .enable_reg = 0x71010,
> + .enable_mask = BIT(0),
> + .hw.init = &(struct clk_init_data){
> + .name = "gcc_gpu_memnoc_gfx_clk",
> +// .flags = CLK_DONT_HOLD_STATE,
This need to be removed/updated
--
~Vinod
next prev parent reply other threads:[~2022-04-11 18:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-08 22:43 [PATCH 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings Bjorn Andersson
2022-04-08 22:43 ` [PATCH 2/2] clk: qcom: add sc8280xp GCC driver Bjorn Andersson
2022-04-11 18:31 ` Vinod Koul [this message]
2022-04-12 19:05 ` Stephen Boyd
2022-04-09 16:41 ` [PATCH 1/2] dt-bindings: clock: Add Qualcomm SC8280XP GCC bindings Krzysztof Kozlowski
2022-04-13 21:05 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlR0B8N443IQZFEN@matsya \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox