public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [RFC PATCH jsarha] BACKPORT: FROMGIT: nvme-pci: nvme_dev_pm_ops can be static
  2022-04-11 19:25 [jsarha:topic/chromeos-4.19-s0ix 7573/9999] drivers/nvme/host/pci.c:2705:25: sparse: sparse: symbol 'nvme_dev_pm_ops' was not declared. Should it be static? kernel test robot
@ 2022-04-11 19:24 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2022-04-11 19:24 UTC (permalink / raw)
  To: Keith Busch; +Cc: kbuild-all, linux-kernel, Rajat Jain, Gwendal Grignou

drivers/nvme/host/pci.c:2705:25: warning: symbol 'nvme_dev_pm_ops' was not declared. Should it be static?

Fixes: bc7304877066 ("BACKPORT: FROMGIT: nvme-pci: Use host managed power state for suspend")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 drivers/nvme/host/pci.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 23f999fef88bcb..a33a32e6787799 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2702,7 +2702,7 @@ static int nvme_suspend(struct device *dev)
 		nvme_simple_suspend(dev) : nvme_deep_state(ndev);
 }
 
-const struct dev_pm_ops nvme_dev_pm_ops = {
+static const struct dev_pm_ops nvme_dev_pm_ops = {
 	.suspend = nvme_suspend,
 	.resume = nvme_resume,
 	.freeze = nvme_simple_suspend,

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [jsarha:topic/chromeos-4.19-s0ix 7573/9999] drivers/nvme/host/pci.c:2705:25: sparse: sparse: symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
@ 2022-04-11 19:25 kernel test robot
  2022-04-11 19:24 ` [RFC PATCH jsarha] BACKPORT: FROMGIT: nvme-pci: nvme_dev_pm_ops can be static kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2022-04-11 19:25 UTC (permalink / raw)
  To: Keith Busch; +Cc: kbuild-all, linux-kernel, Rajat Jain, Gwendal Grignou

tree:   https://github.com/jsarha/linux topic/chromeos-4.19-s0ix
head:   430bdaa0a8c38697780f45a148964d71951df11f
commit: bc7304877066a781782a7b43ea0ed2edcc767637 [7573/9999] BACKPORT: FROMGIT: nvme-pci: Use host managed power state for suspend
config: i386-randconfig-s001-20220411 (https://download.01.org/0day-ci/archive/20220412/202204120348.5EvqQlqc-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-19) 11.2.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/jsarha/linux/commit/bc7304877066a781782a7b43ea0ed2edcc767637
        git remote add jsarha https://github.com/jsarha/linux
        git fetch --no-tags jsarha topic/chromeos-4.19-s0ix
        git checkout bc7304877066a781782a7b43ea0ed2edcc767637
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=i386 SHELL=/bin/bash drivers/nvme/host/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/nvme/host/pci.c:2705:25: sparse: sparse: symbol 'nvme_dev_pm_ops' was not declared. Should it be static?
   drivers/nvme/host/pci.c:1263: warning: Function parameter or member 'nvmeq' not described in 'nvme_suspend_queue'

Please review and possibly fold the followup patch.

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-04-11 19:27 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-11 19:25 [jsarha:topic/chromeos-4.19-s0ix 7573/9999] drivers/nvme/host/pci.c:2705:25: sparse: sparse: symbol 'nvme_dev_pm_ops' was not declared. Should it be static? kernel test robot
2022-04-11 19:24 ` [RFC PATCH jsarha] BACKPORT: FROMGIT: nvme-pci: nvme_dev_pm_ops can be static kernel test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox