From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Krzysztof Kozlowski <krzk@kernel.org>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
Duc Nguyen <duc.nguyen.ub@renesas.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Andrew Gabbasov <andrew_gabbasov@mentor.com>,
linux-renesas-soc@vger.kernel.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] memory: renesas-rpc-if: Simplify single/double data register access
Date: Tue, 12 Apr 2022 11:42:11 +0200 [thread overview]
Message-ID: <YlVJc3z1xXT2emIc@ninjato> (raw)
In-Reply-To: <19358863deae03b1b26f473e878305a1c6e40d19.1649681638.git.geert+renesas@glider.be>
[-- Attachment #1: Type: text/plain, Size: 759 bytes --]
On Mon, Apr 11, 2022 at 02:55:29PM +0200, Geert Uytterhoeven wrote:
> For manual write and read, factor out the common access to the first
> data register by keeping track of the current data pointer.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Works fine with reading/writing on a V3U, so:
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
I agree the code is more concise. I am not sure, though, if it is really
more readable. But I don't mind very much, so except for a small nit:
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> + if (nbytes == 8)
> + regmap_write(rpc->regmap, RPCIF_SMWDR1, *p++);
> + regmap_write(rpc->regmap, RPCIF_SMWDR0, *p++);
Last '++' can be omitted?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-04-12 10:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 12:55 [PATCH] memory: renesas-rpc-if: Simplify single/double data register access Geert Uytterhoeven
2022-04-12 9:42 ` Wolfram Sang [this message]
2022-04-12 9:45 ` Geert Uytterhoeven
2022-04-12 9:49 ` Wolfram Sang
2022-04-12 10:04 ` Geert Uytterhoeven
2022-04-12 10:17 ` Wolfram Sang
2022-04-12 12:19 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlVJc3z1xXT2emIc@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=andrew_gabbasov@mentor.com \
--cc=duc.nguyen.ub@renesas.com \
--cc=geert+renesas@glider.be \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=s.shtylyov@omp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox