From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Javier Martinez Canillas <javierm@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Mark Brown <broonie@kernel.org>, Chen-Yu Tsai <wens@kernel.org>,
Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>
Subject: Re: [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver
Date: Tue, 12 Apr 2022 14:21:08 +0300 [thread overview]
Message-ID: <YlVgpHqqqFy43L37@smile.fi.intel.com> (raw)
In-Reply-To: <4128b288-2b9a-f9cd-01f3-a1d50d3e10bb@redhat.com>
On Tue, Apr 12, 2022 at 10:07:02AM +0200, Javier Martinez Canillas wrote:
> On 4/12/22 09:23, Geert Uytterhoeven wrote:
> > On Mon, Apr 11, 2022 at 11:12 PM Javier Martinez Canillas
> > <javierm@redhat.com> wrote:
...
> >> - ssd130x->device_info = device_get_match_data(dev);
> >> +
> >> + variant = (enum ssd130x_variants)device_get_match_data(dev);
> >
> > (uintptr_t), to avoid a cast from pointer to integer of different
> > size warning.
> >
>
> Indeed. The kernel test robot reported the same.
Not only because of this, but also with the non-NULL pointers I prefer the old
style without ugly castings.
Instead, you may export the array (in the driver's namespace) and use
&info[ID] pointer for the specific device info.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-04-12 12:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-11 21:12 [PATCH v2 0/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 1/5] dt-bindings: display: ssd1307fb: Deprecate "-i2c" compatible strings Javier Martinez Canillas
2022-04-12 7:13 ` Geert Uytterhoeven
2022-04-12 11:28 ` Maxime Ripard
2022-04-12 12:48 ` Javier Martinez Canillas
2022-04-12 12:07 ` Chen-Yu Tsai
2022-04-12 12:49 ` Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 2/5] dt-bindings: display: ssd1307fb: Extend schema for SPI controllers Javier Martinez Canillas
2022-04-12 7:16 ` Geert Uytterhoeven
2022-04-12 8:01 ` Javier Martinez Canillas
2022-04-12 8:07 ` Geert Uytterhoeven
2022-04-12 8:12 ` Javier Martinez Canillas
2022-04-12 18:16 ` Rob Herring
2022-04-11 21:12 ` [PATCH v2 3/5] drm/solomon: Add ssd130x new compatible strings and deprecate old ones Javier Martinez Canillas
2022-04-12 7:19 ` Geert Uytterhoeven
2022-04-12 8:03 ` Javier Martinez Canillas
2022-04-11 21:12 ` [PATCH v2 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver Javier Martinez Canillas
2022-04-12 7:23 ` Geert Uytterhoeven
2022-04-12 8:07 ` Javier Martinez Canillas
2022-04-12 11:21 ` Andy Shevchenko [this message]
2022-04-12 11:22 ` Andy Shevchenko
2022-04-12 12:47 ` Javier Martinez Canillas
2022-04-12 12:45 ` Javier Martinez Canillas
2022-04-12 7:25 ` kernel test robot
2022-04-11 21:12 ` [PATCH v2 5/5] drm/solomon: Add SSD130x OLED displays SPI support Javier Martinez Canillas
2022-04-12 7:31 ` Geert Uytterhoeven
2022-04-12 8:07 ` Javier Martinez Canillas
2022-04-12 8:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlVgpHqqqFy43L37@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=airlied@linux.ie \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh@kernel.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox