From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A976C433F5 for ; Tue, 12 Apr 2022 13:36:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352471AbiDLNiW (ORCPT ); Tue, 12 Apr 2022 09:38:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42558 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356228AbiDLNhz (ORCPT ); Tue, 12 Apr 2022 09:37:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 945B62899F for ; Tue, 12 Apr 2022 06:35:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 26496618F7 for ; Tue, 12 Apr 2022 13:35:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31C33C385A5; Tue, 12 Apr 2022 13:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1649770536; bh=vNQOBDQdMni8jds0z2+VqbUL+Zc+eovCppk8nBmVt/M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AQpdhQ9Jy//mWBYBcfXL7e6OY/PbhclRiMeYneJGshb8YN9EvilTqLP4M8mreulTh kdEQyahAtqhEwKn6huAr4zO2m/ZLUgn3He9gwqlJm4HaFTqWcqzqTD2H6gYZ0vu+aC pFyQgVhsLZTice6QbvAhv026stpiWUTmGiH2p0Tc= Date: Tue, 12 Apr 2022 15:35:33 +0200 From: Greg Kroah-Hartman To: Bruno Moreira-Guedes Cc: Martyn Welch , Manohar Vanga , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev, Bruno's Patch Watchbox Subject: Re: [PATCH v2 1/3] staging: vme: Adjusted VME_USER in Kconfig Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 12, 2022 at 03:55:21AM -0300, Bruno Moreira-Guedes wrote: > Currently, the VME_USER driver is in the staging tree Kconfig, unlike > other VME drivers already moved to the main portions of the kernel tree. > Its configuration is, however, nested into the VME_BUS config option, > which might be misleading. > > Since the staging tree "[...] is used to hold stand-alone[1] drivers and > filesystem that are not ready to be merged into the main portion of the > Linux kernel tree [...]"[1], IMHO all staging drivers should appear > nested into the Main Menu -> Device Drivers -> Staging Drivers to make > sure the user don't pick it without being fully aware of its staging > status as it could be the case in Menu -> Device Drivers -> VME bridge > support (the current location). > > With this change menuconfig users will clearly know this is not a driver > in the main portion of the kernel tree and decide whether to build it or > not with that clearly in mind. > > This change goes into the same direction of commit 4b4cdf3979c3 > ("STAGING: Move staging drivers back to staging-specific menu") > > CHANGELOG > v1: > - Sourced "drivers/staging/vme/devices/Kconfig" in > "drivers/staging/Kconfig" and unsourced in "drivers/vme/Kconfig". > > v2: > - Turned into a patchset to (1) fix missing "depends on" missing entry > in config VME_USER at "drivers/staging/vme/devices/Kconfig", > affecting the behavior of this patch, and (2) fix unnecessary > remaining files from the time the whole vme subtree was in staging. Changelog goes below the --- line please. > REFERENCES > [1] https://lkml.org/lkml/2009/3/18/314 Never reference lkml.org, we have no control over it and it goes down a lot. Please use lore.kernel.org links, and put the link in the body of the text, no need for footnotes. thanks, greg k-h