From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30A64C433F5 for ; Tue, 12 Apr 2022 14:29:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1356539AbiDLObr (ORCPT ); Tue, 12 Apr 2022 10:31:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351937AbiDLObi (ORCPT ); Tue, 12 Apr 2022 10:31:38 -0400 Received: from mail-oa1-x2c.google.com (mail-oa1-x2c.google.com [IPv6:2001:4860:4864:20::2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3D0627CDF for ; Tue, 12 Apr 2022 07:29:18 -0700 (PDT) Received: by mail-oa1-x2c.google.com with SMTP id 586e51a60fabf-de3eda6b5dso20973969fac.0 for ; Tue, 12 Apr 2022 07:29:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GxA+wuzS2VTnaCpw8/DQnNsOeYcblk4406tgOs1kPrI=; b=MH0U2Ei66jCCDx0swymTSyZNk3sqbf2rY3WLX5Pwrwu1nh4V8Y30+ZB3CqJ1LQTgYF RW6NfbBcMkKOLWwftzRLiHSJBGsZD7uVe1vSQ4XPpr3C+w9StxSqyq39xfujlxaCzZEA jh1nYCzV2j1fN0bitFi8h9P9jpzUWygVsUE/JfpK8emwb9gw7IGIrpA+ga80zMSiiJbk sQ4E87/XQxmcKR07uUxArDcPJ/l4LmYlza7SP9SO5H2V9EjHZpBqti6iDGJM1tNIsN5P QrJVCvwLMoVMNAFUcdQCeKSfHTQHoV+PtB0amwIE5Sy4AN4cRWRSiiMauKoIpfpZshw/ 4iBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GxA+wuzS2VTnaCpw8/DQnNsOeYcblk4406tgOs1kPrI=; b=zfXdbxtCQbDLPoBbrH3tZTnkyw0AUx2ttKCi/rg1A1EDPPfvCVWwRnwWz0d8ogMtxK Cm0ZjT6EnzWQ+rjmOozKAviv7lSGTYE4sQuU+31qeNfpZ/ffi+X7FlH2SPDm3D9QMTjs SzfxgMzI8W3jrqhXUKGvXgjHCcP3MlTUfoFWqcGeSVb/z911NFZc3hr/3ID8JquacQ9/ GKtkXusejKOGZRc2f8IcSogtwGnRd+yjfAXSQ2hq0DpXL9o9KlpC4y1/trl4ws/Kj7Vy 2Jl131xRC5/uL33fAyzBSJTkDfLm38HlHcFoGfxLKY4E/aFI5GETESslcFM/JXao4rHx +Q+w== X-Gm-Message-State: AOAM531mTFIFhTsPcdhl3m7I9DLzzCbM46gsKNf8c/5/3FY52q8JrJpO Q0LGWsJMm2JAL0Gp3fh7GUXgjJ+n8QNgmkHr X-Google-Smtp-Source: ABdhPJxZW+yVNF/lJYAiuoC2KDAAc81y2wKm3Y8r2ObfycQAn7jcAdHMNb2ptE++bS1LUV+uIg2qCw== X-Received: by 2002:a05:6870:b40a:b0:d7:5c87:64ab with SMTP id x10-20020a056870b40a00b000d75c8764abmr2204624oap.168.1649773758139; Tue, 12 Apr 2022 07:29:18 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id r82-20020aca5d55000000b002ecaaa13cafsm12579555oib.8.2022.04.12.07.29.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 07:29:17 -0700 (PDT) Date: Tue, 12 Apr 2022 09:29:15 -0500 From: Bjorn Andersson To: cgel.zte@gmail.com Cc: agross@kernel.org, srinivas.kandagatla@linaro.org, gregkh@linuxfoundation.org, sdharia@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Subject: Re: [PATCH] slimbus: qcom: fix error check return value of platform_get_irq() Message-ID: References: <20220412090259.2533316-1-lv.ruyi@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412090259.2533316-1-lv.ruyi@zte.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 12 Apr 04:02 CDT 2022, cgel.zte@gmail.com wrote: > From: Lv Ruyi > > platform_get_irq() return negative value on failure, so null check of > ctrl->irq is incorrect. Fix it by comparing whether it is less than zero. > > Fixes: ad7fcbc308b0 ("slimbus: qcom: Add Qualcomm Slimbus controller driver") > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi Reviewed-by: Bjorn Andersson > --- > drivers/slimbus/qcom-ctrl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c > index f04b961b96cd..b2f01e155d77 100644 > --- a/drivers/slimbus/qcom-ctrl.c > +++ b/drivers/slimbus/qcom-ctrl.c > @@ -510,7 +510,7 @@ static int qcom_slim_probe(struct platform_device *pdev) > } > > ctrl->irq = platform_get_irq(pdev, 0); > - if (!ctrl->irq) { > + if (ctrl->irq < 0) { > dev_err(&pdev->dev, "no slimbus IRQ\n"); > return -ENODEV; > } > -- > 2.25.1 >