From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F287C433EF for ; Tue, 12 Apr 2022 20:54:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229632AbiDLU5K (ORCPT ); Tue, 12 Apr 2022 16:57:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229379AbiDLU5G (ORCPT ); Tue, 12 Apr 2022 16:57:06 -0400 Received: from mail-ot1-x32d.google.com (mail-ot1-x32d.google.com [IPv6:2607:f8b0:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31030147537 for ; Tue, 12 Apr 2022 13:52:13 -0700 (PDT) Received: by mail-ot1-x32d.google.com with SMTP id n19-20020a9d7113000000b005cd9cff76c3so14196975otj.1 for ; Tue, 12 Apr 2022 13:52:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=E/sfuAYENU6UCHVTWqjFkHV1/OSU1AIAFVjMvfNyJ5k=; b=wHUAnWUOVTPZ0YoLJMOSVtGGQZHYba4E5Nb/7yndemn1YzYnQDp9JX7Sla5M/2OShh JdHuMh9a0HG+wltK0D/G9iflV38ag2iC5fwzIEV6lYXZ6q8xNlDmQRf++iJpG4q8muyA Uj9eGVzjzNR6o+qx5utWqwZ/1XMP/GISj9MAkqTwtHnMLIjVoNtNHrhD4wRh3uLwVWbF EEpjn9NRHsbk1v5PFGsXFfXsZs3jIelQBHh+SFG5pXIppMvUeYTKBcVuNTtofrgKbI2P 4tXBqNzsWur6OZt6If3nTcdsTaHpwlqRUSU6h8/P1x8EBYqwlyiuQbqvwfvKEE0uCDMI ncSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=E/sfuAYENU6UCHVTWqjFkHV1/OSU1AIAFVjMvfNyJ5k=; b=Ldct07oTfE2K/iL8WNKHwZm0M8Dh0rtBXUEqyVsoFxZ0PR/gFTpq+kmyXZ/G//lXsy xKIENfGp3wBOw5H0mQKewnwG4i21cUqIEQgdWguL+hS+CmOQpEcha50PeHy73rgk1TXx UtVVCkG10vxcBD6UKbnigLqcAtXzMRwIML/Lzatws4O+RZBB1js7tt3Mm16Ayt9dFS8J pIHeWQvmjw8tkKqm/y5f6HcWQrzHmv741oMAFElcuEnYKmNyex51bHma0pVb6pLEOD6o 9Avqrdx2jAziKFtLWFXl46MZ3ykR0NpbVRJSIc3o+bp7LIqt4vXFT7RfE2p9s1PLe6xX 83vQ== X-Gm-Message-State: AOAM533B6EYWrt/q3rtPMlhMDp2Z2HeD5NOSwfSijK0yngPRLB93NtEt qYMsOaaLcCFG4SVNQNDucqqxUA== X-Google-Smtp-Source: ABdhPJwjcIvzgdEJLnuijwZQ02tCKe+ogBaa/q1YYFlZAZ+Xy8RMe6e4X1zADMRvNMJtvgts4wtLqA== X-Received: by 2002:a05:6830:4409:b0:5cd:ad47:5b47 with SMTP id q9-20020a056830440900b005cdad475b47mr14024722otv.49.1649796687913; Tue, 12 Apr 2022 13:51:27 -0700 (PDT) Received: from builder.lan ([2600:1700:a0:3dc8:3697:f6ff:fe85:aac9]) by smtp.gmail.com with ESMTPSA id u20-20020a4a9e94000000b003291f6ac4b2sm12602878ook.28.2022.04.12.13.51.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 13:51:27 -0700 (PDT) Date: Tue, 12 Apr 2022 15:51:25 -0500 From: Bjorn Andersson To: Jonathan Marek Cc: linux-arm-msm@vger.kernel.org, Andy Gross , Rob Herring , Krzysztof Kozlowski , Vinod Koul , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH] arm64: dts: qcom: sm8450: delete incorrect ufs interconnect fields Message-ID: References: <20220407172145.31903-1-jonathan@marek.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220407172145.31903-1-jonathan@marek.ca> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 07 Apr 12:21 CDT 2022, Jonathan Marek wrote: > Upstream sm8450.dtsi has #interconnect-cells = <2>; so these are wrong. > Ignored and undocumented with upstream UFS driver so delete for now. > Just to clarify, the binding do document interconnects and the property should be there in the end. v1 (why isn't this marked v2?) was correct. What I asked for was a statement on why it should be picked up for v5.18-rc (as Dmitry requested). Regards, Bjorn > Fixes: aa2d0bf04a3c ("arm64: dts: qcom: sm8450: add interconnect nodes") > Signed-off-by: Jonathan Marek > --- > arch/arm64/boot/dts/qcom/sm8450.dtsi | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi > index 2c18e1ef9e82d..90cdbec3cac99 100644 > --- a/arch/arm64/boot/dts/qcom/sm8450.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi > @@ -1663,9 +1663,6 @@ ufs_mem_hc: ufshc@1d84000 { > > iommus = <&apps_smmu 0xe0 0x0>; > > - interconnects = <&aggre1_noc MASTER_UFS_MEM &mc_virt SLAVE_EBI1>, > - <&gem_noc MASTER_APPSS_PROC &config_noc SLAVE_UFS_MEM_CFG>; > - interconnect-names = "ufs-ddr", "cpu-ufs"; > clock-names = > "core_clk", > "bus_aggr_clk", > -- > 2.26.1 >