From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A06CC433EF for ; Tue, 12 Apr 2022 21:30:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230263AbiDLVck (ORCPT ); Tue, 12 Apr 2022 17:32:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229602AbiDLVce (ORCPT ); Tue, 12 Apr 2022 17:32:34 -0400 Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2A60195300; Tue, 12 Apr 2022 14:11:10 -0700 (PDT) Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-dacc470e03so53892fac.5; Tue, 12 Apr 2022 14:11:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=cJkmHfdBxf221GLO6Rp2mXWctk7aSf4CdfI04IRAEBI=; b=6U/sVTT7gZL4hR4AZy8BvzKuik3sdGMReHESQH0rDQ3DwlSCuHryyT6Ii0x95rZ6YF 25dPv43Wt/tUkPtW/IIVgzfQuMOOfmOhZlVwyUD2UCA63RGYyr/q2XAGTgCdgNj8DoSR c5Ri9fA2SQrcppbEADVHj/QN1lKWe5Az8E5X2BO3fbubEJpO+aiEa8zlQiRlESBPXpm8 BRUltZybWfYyb/1YXI7ZYC17tWTATodSwr4Hh39csrqnU0wg7C2QRwEn/TsXlUYBiyon zQ0gCTTZ2sKiKjyH07pZju1ujwnsN660c0AmNyWjtGbZCI9mSPstfVP/5M1eqxSyHinw N6AQ== X-Gm-Message-State: AOAM5311hNhnTMemh4aReCIR/BUFhLhTNyIZG2/yuaibrmQwU7oyh26r WFonfvBzLIOQcDHYvThpTw== X-Google-Smtp-Source: ABdhPJxzHVBv05OKxWV0sTv8Hm3nF460ieQSkUefeU8+7dcceq2HdX1Y1OEyRNmYiktpO+V5nGy4WA== X-Received: by 2002:a05:6870:4290:b0:e2:b4c9:ea5a with SMTP id y16-20020a056870429000b000e2b4c9ea5amr2900806oah.173.1649797740517; Tue, 12 Apr 2022 14:09:00 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d1-20020a056830138100b005cf2f29d89csm13533691otq.77.2022.04.12.14.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:09:00 -0700 (PDT) Received: (nullmailer pid 946357 invoked by uid 1000); Tue, 12 Apr 2022 21:08:59 -0000 Date: Tue, 12 Apr 2022 16:08:59 -0500 From: Rob Herring To: Samuel Holland Cc: Chen-Yu Tsai , Jernej Skrabec , Maxime Ripard , Daniel Vetter , David Airlie , Krzysztof Kozlowski , devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, Krzysztof Kozlowski Subject: Re: [PATCH v2 02/14] dt-bindings: display: Add D1 display engine compatibles Message-ID: References: <20220412042807.47519-1-samuel@sholland.org> <20220412042807.47519-3-samuel@sholland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412042807.47519-3-samuel@sholland.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 11, 2022 at 11:27:54PM -0500, Samuel Holland wrote: > Allwinner D1 contains a display engine 2.0. It features two mixers, a > TCON TOP (with DSI and HDMI), one TCON LCD, and one TCON TV. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Samuel Holland > --- > > (no changes since v1) > > .../allwinner,sun4i-a10-display-engine.yaml | 1 + > .../display/allwinner,sun4i-a10-tcon.yaml | 2 ++ > .../allwinner,sun8i-a83t-de2-mixer.yaml | 2 ++ > .../display/allwinner,sun8i-r40-tcon-top.yaml | 34 +++++++++++++++++++ > 4 files changed, 39 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > index d4412aea7b73..c388ae5da1e4 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-display-engine.yaml > @@ -62,6 +62,7 @@ properties: > - allwinner,sun8i-r40-display-engine > - allwinner,sun8i-v3s-display-engine > - allwinner,sun9i-a80-display-engine > + - allwinner,sun20i-d1-display-engine > - allwinner,sun50i-a64-display-engine > - allwinner,sun50i-h6-display-engine > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > index 3a7d5d731712..4a92a4c7dcd7 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun4i-a10-tcon.yaml > @@ -33,6 +33,8 @@ properties: > - const: allwinner,sun8i-v3s-tcon > - const: allwinner,sun9i-a80-tcon-lcd > - const: allwinner,sun9i-a80-tcon-tv > + - const: allwinner,sun20i-d1-tcon-lcd > + - const: allwinner,sun20i-d1-tcon-tv > > - items: > - enum: > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > index 4f91eec26de9..cb243bc58ef7 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-a83t-de2-mixer.yaml > @@ -19,6 +19,8 @@ properties: > - allwinner,sun8i-r40-de2-mixer-0 > - allwinner,sun8i-r40-de2-mixer-1 > - allwinner,sun8i-v3s-de2-mixer > + - allwinner,sun20i-d1-de2-mixer-0 > + - allwinner,sun20i-d1-de2-mixer-1 > - allwinner,sun50i-a64-de2-mixer-0 > - allwinner,sun50i-a64-de2-mixer-1 > - allwinner,sun50i-h6-de3-mixer-0 > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > index 784b267635fb..cc32e2faed91 100644 > --- a/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > +++ b/Documentation/devicetree/bindings/display/allwinner,sun8i-r40-tcon-top.yaml > @@ -41,6 +41,7 @@ properties: > compatible: > enum: > - allwinner,sun8i-r40-tcon-top > + - allwinner,sun20i-d1-tcon-top > - allwinner,sun50i-h6-tcon-top > > reg: > @@ -154,6 +155,39 @@ allOf: > - port@2 > - port@3 > > + - if: > + properties: > + compatible: > + contains: > + const: allwinner,sun20i-d1-tcon-top > + > + then: > + properties: > + clocks: > + minItems: 4 > + maxItems: 4 You shouldn't need minItems and maxItems here and the next 2 cases. > + items: > + - description: The TCON TOP interface clock > + - description: The TCON TOP TV0 clock > + - description: The TCON TOP TVE0 clock > + - description: The TCON TOP MIPI DSI clock > + > + clock-names: > + minItems: 4 > + maxItems: 4 > + items: > + - const: bus > + - const: tcon-tv0 > + - const: tve0 > + - const: dsi > + > + clock-output-names: > + minItems: 2 > + maxItems: 2 > + items: > + - description: TCON TV0 output clock name > + - description: DSI output clock name > + > - if: > properties: > compatible: > -- > 2.35.1 > >