From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB04CC433EF for ; Tue, 12 Apr 2022 23:24:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229750AbiDLX00 (ORCPT ); Tue, 12 Apr 2022 19:26:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229877AbiDLXZ5 (ORCPT ); Tue, 12 Apr 2022 19:25:57 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB85089301 for ; Tue, 12 Apr 2022 15:12:06 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id p65so487370ybp.9 for ; Tue, 12 Apr 2022 15:12:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=n/5q6ebK0JYN5I7SWFxTUh10KRu428isEGA+YMY0xN4=; b=sWx01FzQ52rz4TlVeDegxVNeDfmRcpQfNXdHuvalmZDAgtXROZkhFaSuKhNQNiEgKI WvlFxWz+QV5Kp6fkSTGX852h4t/pl5pqUJqvuJIOqiEc8LSxKkt8rUF1kXEbKFDR1EzA 8+CdvnE7j9qnxeZC8NukluEOv3a4ZauSz4IIdkSmPZjE27pZPt3Ai6KPB1GJeHtjtnZJ f76ruUOfVhARU9cgrFz35mWiNg+SFn+TcMSHqSp5wIbAF7l8BJ4NOEdtAFeVCps1Pig9 WZvxSzQLJqSs1bqX7Cgtx/9Ck/qm30gPflZI0IzmDZVBgu72PlUQJ227r/wzW9kqbs5v kdBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=n/5q6ebK0JYN5I7SWFxTUh10KRu428isEGA+YMY0xN4=; b=kHqrvQpl5ZIeSWIrcFx/t5g1rz08CX0Sfps1DM2p4603HmKd53w5dB5HvRNcVENP6R XZJxRfAeSX4AgnaDJb9PT+3MgnL0vaLm9ydQhV2VixownwFq9PIO9GSZbffWe8B/yWa4 6YPcL8q1PbjNJoDmr+w8udRv6xvo42kkFGioaVRUk9fFI9Vqf53kHByG4h2MC9sOCPhx v0lLIJL3MbhFWeJZTjhJ2RMezT3zQV5PbNmXMPskMuhZg/XRXrmqYa4GmPmIdlaljTxB s4sQg7YY3ErALiCiRVCtkQoWrrVA2qpJf4u2yWufMwChVntnXlDL7RzcrwdiQWSwCn5p 5Qdg== X-Gm-Message-State: AOAM531ZjeY/MWD03LA+tdJ3+H9F3J1NXxeMASP6CrYeJKtFm++Yfgdl qbKrI+EPeUX6p+XLtYMkvhTdaPBDGX0mj9EN X-Google-Smtp-Source: ABdhPJzM73G6wmlf7ocdRD76spYGYiPKpTlOlDLnwAhgIxZiQVyrqx/COh0e31S0X6g2LDDnvC7doA== X-Received: by 2002:a9d:4709:0:b0:5cd:9619:890f with SMTP id a9-20020a9d4709000000b005cd9619890fmr13115445otf.118.1649798943160; Tue, 12 Apr 2022 14:29:03 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id 123-20020a4a0181000000b00324a1217e96sm13290162oor.35.2022.04.12.14.29.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 14:29:02 -0700 (PDT) Date: Tue, 12 Apr 2022 14:31:17 -0700 From: Bjorn Andersson To: Vinod Koul Cc: linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] dmaengine: qcom: gpi: Add support for ee_offset Message-ID: References: <20220406132508.1029348-1-vkoul@kernel.org> <20220406132508.1029348-3-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220406132508.1029348-3-vkoul@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 06 Apr 06:25 PDT 2022, Vinod Koul wrote: > Controller on newer SoCs like SM8450 have registers at at offset. Add > ee_offset to driver_data and add this compatible for the driver. > > Signed-off-by: Vinod Koul Reviewed-by: Bjorn Andersson Tested-by: Bjorn Andersson Regards, Bjorn > --- > drivers/dma/qcom/gpi.c | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index 3429ceccd13b..0b402d923eae 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -2152,6 +2152,7 @@ static int gpi_probe(struct platform_device *pdev) > { > struct gpi_dev *gpi_dev; > unsigned int i; > + u32 ee_offset; > int ret; > > gpi_dev = devm_kzalloc(&pdev->dev, sizeof(*gpi_dev), GFP_KERNEL); > @@ -2179,6 +2180,9 @@ static int gpi_probe(struct platform_device *pdev) > return ret; > } > > + ee_offset = (uintptr_t)device_get_match_data(gpi_dev->dev); > + gpi_dev->ee_base = gpi_dev->ee_base - ee_offset; > + > gpi_dev->ev_factor = EV_FACTOR; > > ret = dma_set_mask(gpi_dev->dev, DMA_BIT_MASK(64)); > @@ -2282,9 +2286,10 @@ static int gpi_probe(struct platform_device *pdev) > } > > static const struct of_device_id gpi_of_match[] = { > - { .compatible = "qcom,sdm845-gpi-dma" }, > - { .compatible = "qcom,sm8150-gpi-dma" }, > - { .compatible = "qcom,sm8250-gpi-dma" }, > + { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, > + { .compatible = "qcom,sm8150-gpi-dma", .data = (void *)0x0 }, > + { .compatible = "qcom,sm8250-gpi-dma", .data = (void *)0x0 }, > + { .compatible = "qcom,sm8450-gpi-dma", .data = (void *)0x10000 }, > { }, > }; > MODULE_DEVICE_TABLE(of, gpi_of_match); > -- > 2.34.1 >