From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99781C433F5 for ; Wed, 13 Apr 2022 10:49:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234981AbiDMKwR (ORCPT ); Wed, 13 Apr 2022 06:52:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50796 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231622AbiDMKwO (ORCPT ); Wed, 13 Apr 2022 06:52:14 -0400 Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B403C35858 for ; Wed, 13 Apr 2022 03:49:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649846992; x=1681382992; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=24MmeEn2Cbl39Z9DZndnyl+5AVJ6TfhTumGasuy47do=; b=Z94uTTS3c7NoBUaIgInaSWig6IrAgRICXK/y5gWDlv/nKpqcoV+Oq03B xYLFJRF1gb8JV7ytwBKOeJAB2AYH1aEeHfRTx4wqXaMIgVx5sUHgbXi7E XPjwDIcdPtaMY5yYFWmIjiWnoGLHSyYicCKTOF6jtqG54kf0xNg3jDxcS 9Gp3r1dGX1BsPNm6d9GIedlOw7Z4BMN5Ypuib6itbGWgRSZdnMIeoOz5R eUhx9Jtu4JvV/VaWP+9Ul6CMbvpYQqmbr687bMBMSAHo+DPzir5Zaqe3f 08TXPj98G0uY/kDP1/5BduLHxaZcTwhnlzvo97rSz15KCNa6JImy13Vt/ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10315"; a="262077085" X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="262077085" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 03:49:52 -0700 X-IronPort-AV: E=Sophos;i="5.90,256,1643702400"; d="scan'208";a="660883901" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2022 03:49:49 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.95) (envelope-from ) id 1neaVm-001nR0-8j; Wed, 13 Apr 2022 13:46:10 +0300 Date: Wed, 13 Apr 2022 13:46:10 +0300 From: Andy Shevchenko To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Geert Uytterhoeven , Neil Armstrong , Rob Herring , dri-devel@lists.freedesktop.org, Mark Brown , Chen-Yu Tsai , Geert Uytterhoeven , Daniel Vetter , David Airlie Subject: Re: [PATCH v3 4/5] drm/solomon: Move device info from ssd130x-i2c to the core driver Message-ID: References: <20220412162729.184783-1-javierm@redhat.com> <20220412162729.184783-5-javierm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220412162729.184783-5-javierm@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 12, 2022 at 06:27:28PM +0200, Javier Martinez Canillas wrote: > These are declared in the ssd130x-i2c transport driver but the information > is not I2C specific, and could be used by other SSD130x transport drivers. > > Move them to the ssd130x core driver and just set the OF device entries to > an ID that could be used to lookup the correct device info from an array. > > While being there, also move the SSD130X_DATA and SSD130X_COMMAND control > bytes. Since even though they are used by the I2C interface, they could > also be useful for other transport protocols such as SPI. ... > +EXPORT_SYMBOL_GPL(ssd130x_variants); What I meant is to use EXPORT_SYMBOL_NS_GPL() here. It might require a separate patch to move other exports to that namespace first. -- With Best Regards, Andy Shevchenko