From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Colin Ian King <colin.i.king@gmail.com>
Cc: linux-staging@lists.linux.dev, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: rtl8192u: make read-only array EWC11NHTCap static const
Date: Thu, 14 Apr 2022 12:26:00 +0200 [thread overview]
Message-ID: <Ylf2uDiVLniQiACK@kroah.com> (raw)
In-Reply-To: <20220414101838.296944-1-colin.i.king@gmail.com>
On Thu, Apr 14, 2022 at 11:18:38AM +0100, Colin Ian King wrote:
> Don't populate the read-only array EWC11NHTCap on the stack but instead
> make it static const. Also makes the object code a little smaller. Move
> comment to clean up checkpatch warning.
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> index 358c35d9589c..b4cbe499ba37 100644
> --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
> @@ -480,7 +480,8 @@ void HTConstructCapabilityElement(struct ieee80211_device *ieee, u8 *posHTCap, u
> }
> memset(posHTCap, 0, *len);
> if (pHT->ePeerHTSpecVer == HT_SPEC_VER_EWC) {
> - u8 EWC11NHTCap[] = {0x00, 0x90, 0x4c, 0x33}; // For 11n EWC definition, 2007.07.17, by Emily
> + /* For 11n EWC definition, 2007.07.17, by Emily */
This is not needed anymore, you know this...
Just delete it please.
thanks,
greg k-h
prev parent reply other threads:[~2022-04-14 10:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 10:18 [PATCH] staging: rtl8192u: make read-only array EWC11NHTCap static const Colin Ian King
2022-04-14 10:26 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ylf2uDiVLniQiACK@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox