Re: [PATCH v7 4/6] dax: add DAX_RECOVERY flag and .recovery_write dev_pgmap_ops

Jane Chu
2022-04-14T00:48:05Z

On 4/6/2022 10:30 PM, Christoph Hellwig wrote:
> On Wed, Apr 06, 2022 at 05:32:31PM +0000, Jane Chu wrote:
>> Yes, I believe Dan was motivated by avoiding the dm dance as a result of
>> adding .recovery_write to dax_operations.
>>
>> I understand your point about .recovery_write is device specific and
>> thus not something appropriate for device agnostic ops.
>>
>> I can see 2 options so far -
>>
>> 1) add .recovery_write to dax_operations and do the dm dance to hunt
>> down to the base device that actually provides the recovery action
>
> That would be my preference. But I'll wait for Dan to chime in.

Okay.

>
>> Okay, will run the checkpatch.pl test again.
>
> Unfortuntely checkpatch.pl is broken in that regard. It treats the
> exception to occasionally go longer or readability as the default.

I see.

thanks,
-jane