Re: [PATCH v7 1/6] x86/mm: fix comment

Jane Chu
2022-04-14T01:00:50Z

On 4/12/2022 2:53 AM, Borislav Petkov wrote:
> On Tue, Apr 05, 2022 at 01:47:42PM -0600, Jane Chu wrote:
>> There is no _set_memory_prot internal helper, while coming across
>> the code, might as well fix the comment.
>>
>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>> Signed-off-by: Jane Chu <jane.chu@oracle.com>
>> ---
>> arch/x86/mm/pat/set_memory.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c
>> index abf5ed76e4b7..38af155aaba9 100644
>> --- a/arch/x86/mm/pat/set_memory.c
>> +++ b/arch/x86/mm/pat/set_memory.c
>> @@ -1816,7 +1816,7 @@ static inline int cpa_clear_pages_array(struct page **pages, int numpages,
>> }
>>
>> /*
>> - * _set_memory_prot is an internal helper for callers that have been passed
>> + * __set_memory_prot is an internal helper for callers that have been passed
>> * a pgprot_t value from upper layers and a reservation has already been taken.
>> * If you want to set the pgprot to a specific page protocol, use the
>> * set_memory_xx() functions.
>> --
>
> This is such a trivial change so that having it as a separate patch is
> probably not needed - might as well merge it with patch 3...

This change used to be folded in the mce patch, but for that I received
a review comment pointing out that the change is unrelated to the said
patch and doesn't belong, hence I pulled it out to stand by itself. :)

thanks!
-jane

>
> Thx.
>