From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B8C6C4332F for ; Thu, 14 Apr 2022 15:45:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358113AbiDNPlM (ORCPT ); Thu, 14 Apr 2022 11:41:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42686 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1354780AbiDNOmh (ORCPT ); Thu, 14 Apr 2022 10:42:37 -0400 Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FBD8DEA8 for ; Thu, 14 Apr 2022 07:39:36 -0700 (PDT) Received: by mail-pj1-x102a.google.com with SMTP id i24-20020a17090adc1800b001cd5529465aso4782520pjv.0 for ; Thu, 14 Apr 2022 07:39:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gJ8pcz3Yaw1gKMnr6f7nkiOA+qMs14RS4sjJplU0gjM=; b=R4JJPAxBiFl6PYRwZGRkCFzqF4VwdjE3sCH/tcEdYlbUlKE40ftv4JdLWisRcFdYD+ ZLPXO8yK68lWcdip9fPvd539XPVr0LDMwcHJYld7xq+NTMqK4zO/fBnRDPY4ReezcpiT JdwrQMgNMvGbpSuS30JR74qg3aQuKtF2S2RQYN1PhbM0k3BNLsaBiv45OV5UWZagEa4u Jr/VESJVUOAcZAQr/ZCswkJRgxe1UdqlQiNNfmilwIZIwDOp5tfmoIHRHxAvjoNxXnN+ EQ1InC2XexhkzFjVnN9GiHdeciEeyR+KRFdB1lWMlL1esYJgtlNQfvZN9wS2wH7Tk5On Io6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gJ8pcz3Yaw1gKMnr6f7nkiOA+qMs14RS4sjJplU0gjM=; b=u3btk27K+qosmEszuLeg+vgHxQQUW7XVnRAqH+N0bTudsSu4xbVZj8TZDzPRTms7dm TpgbIVHyiV1JYU8VW00qsGOjaWwdo7nVRPMBATrYXGdruMlSL27de35Rpw2IHCcYhfUb dDybRiP3ReOfi7bW2BPB7idBAv90wkCxOieuc9UClKzeIJS44UndPTKzLEqXkXjMFoHi zOEotiRWEAusVI7kMxFyvX8yMTa0jzZYuQpTVzIUZgdpjkzTWR/ykl6BSMAl3VXJBRm9 Ucmlp2EhLuWMkHv78TXSYc5ID51jUXp0uHLgn0UpyhLVkQd35bivhu8tYlt3hN6mzhfQ tbzQ== X-Gm-Message-State: AOAM5304UQnje10cWH8N9TB5EdiRzK0z1r04/xJAAVwLz+tsWum7nyBX EgHFj9GKfTIsZqxjjknAMXkMkA== X-Google-Smtp-Source: ABdhPJyQhgIYo4iouGyYUQ+Q7Nt/zlHN4/wmdz2jjSvmkYXLB9lHmvXGarXlMm7Az348QWDplNeaIw== X-Received: by 2002:a17:903:110c:b0:14d:8859:5c8 with SMTP id n12-20020a170903110c00b0014d885905c8mr47115691plh.156.1649947176324; Thu, 14 Apr 2022 07:39:36 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id p10-20020a056a0026ca00b004fb44e0cb17sm178299pfw.116.2022.04.14.07.39.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 14 Apr 2022 07:39:35 -0700 (PDT) Date: Thu, 14 Apr 2022 14:39:32 +0000 From: Sean Christopherson To: Colin Ian King Cc: Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , kvm@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: VMX: make read-only const array vmx_uret_msrs_list static Message-ID: References: <20220414100720.295502-1-colin.i.king@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220414100720.295502-1-colin.i.king@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 14, 2022, Colin Ian King wrote: > Don't populate the read-only array vmx_uret_msrs_list on the stack > but instead make it static. Also makes the object code a little smaller. Why not put it on the stack? It's an __init function, i.e. called once in the lifetime of kvm-intel.ko, isn't all that big, and is certainly not performance critical. And making it static begs the question of whether or not the data gets thrown away after init, i.e. this might consume _more_ memory once KVM has reached steady state. > Signed-off-by: Colin Ian King > --- > arch/x86/kvm/vmx/vmx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c > index c654c9d76e09..36429e2bb918 100644 > --- a/arch/x86/kvm/vmx/vmx.c > +++ b/arch/x86/kvm/vmx/vmx.c > @@ -7871,7 +7871,7 @@ static __init void vmx_setup_user_return_msrs(void) > * but is never loaded into hardware. MSR_CSTAR is also never loaded > * into hardware and is here purely for emulation purposes. > */ > - const u32 vmx_uret_msrs_list[] = { > + static const u32 vmx_uret_msrs_list[] = { > #ifdef CONFIG_X86_64 > MSR_SYSCALL_MASK, MSR_LSTAR, MSR_CSTAR, > #endif > -- > 2.35.1 >