Re: [PATCH net-next 09/12] ARM: dts: r9a06g032: describe MII converter

Andrew Lunn
2022-04-15T16:20:04Z

> I think it would be good to modify it like this:
>
> eth-miic@44030000 {
> ...
> converters {
> mii_conv0: mii-conv@0 {
> // Even if useless, maybe keeping it for the sake of coherency
> renesas,miic-input = <MIIC_GMAC1>;
> reg = <0>;
> };

This is not a 'bus', so using reg, and @0, etc is i think wrong. You
just have a collection of properties.

> mii_conv1: mii-conv@1 {
> renesas,miic-input = <SWITCH_PORTA>;
> reg = <1>;
> };
> mii_conv2: mii-conv@2 {
> renesas,miic-input = <SWITCH_PORTB>;
> reg = <2>;
> };
> mii_conv3: mii-conv@3 {
> renesas,miic-input = <SWITCH_PORTC>;
> reg = <3>;
> };
> mii_conv4: mii-conv@4 {
> renesas,miic-input = <SWITCH_PORTD>;
> reg = <4>;
> };
> };
>
> This way, it remains tied to the MII converter output port definition. I
> guess that the yaml definitions would still allow to restrict the values
> available per nodes. Validation for the final combination is probably
> more difficult to do using yaml.

I doubt you can do full validation in YAML. But you can at least limit
some of the errors. You need to do full validation in the driver
anyway.

Andrew