Re: [PATCH net-next 04/12] net: pcs: add Renesas MII converter driver

Geert Uytterhoeven
2022-04-20T13:26:14Z

Hi Clément,

Thanks for your patch!
Only cosmetic comments from me, as I'm not too familiar with MII.

On Thu, Apr 14, 2022 at 2:24 PM Clément Léger <clement.leger@bootlin.com> wrote:
> Add PCS driver for the MII converter that is present on Renesas RZ/N1

Add a ... on the ...

> SoC. This MII converter is reponsible of converting MII to RMII/RGMII

responsible for

> or act as a MII passtrough. Exposing it as a PCS allows to reuse it

pass-through

> in both the switch driver and the stmmac driver. Currently, this driver
> only allows the PCS to be used by the dual Cortex-A7 subsystem since
> the register locking system is not used.
>
> Signed-off-by: Clément Léger <clement.leger@bootlin.com>

> --- a/drivers/net/pcs/Kconfig
> +++ b/drivers/net/pcs/Kconfig
> @@ -18,4 +18,11 @@ config PCS_LYNX
> This module provides helpers to phylink for managing the Lynx PCS
> which is part of the Layerscape and QorIQ Ethernet SERDES.
>
> +config PCS_RZN1_MIIC
> + tristate "Renesas RZN1 MII converter"

RZ/N1

> + help
> + This module provides a driver for the MII converter that is available
> + on RZN1 SoC. This PCS convert MII to RMII/RGMII or can be in

RZ/N1

> + passthrough mode for MII.
> +
> endmenu

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds