From: Peter Zijlstra <peterz@infradead.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
John Stultz <john.stultz@linaro.org>,
Stephen Boyd <sboyd@kernel.org>
Subject: Re: [patch 2/3] timekeeping: Mark tk_clock_read() __always_inline
Date: Fri, 15 Apr 2022 14:09:06 +0200 [thread overview]
Message-ID: <YllgYuZ2jJvQbfZo@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20220415091921.014937522@linutronix.de>
On Fri, Apr 15, 2022 at 11:19:36AM +0200, Thomas Gleixner wrote:
> Compilers can uninline this which makes the notrace annotation of the NMI
> safe accessors moot.
inline already implies notrace.
No objection to making it __always_inline, but this reason doesn't
really work.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> kernel/time/timekeeping.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/kernel/time/timekeeping.c
> +++ b/kernel/time/timekeeping.c
> @@ -186,7 +186,7 @@ static inline void tk_update_sleep_time(
> * a read of the fast-timekeeper tkrs (which is protected by its own locking
> * and update logic).
> */
> -static inline u64 tk_clock_read(const struct tk_read_base *tkr)
> +static __always_inline u64 tk_clock_read(const struct tk_read_base *tkr)
> {
> struct clocksource *clock = READ_ONCE(tkr->clock);
>
>
next prev parent reply other threads:[~2022-04-15 12:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 9:19 [patch 0/3] timekeeping: Janitorial updates Thomas Gleixner
2022-04-15 9:19 ` [patch 1/3] timekeeping: Annotate ktime_get_boot_fast_ns() with data_race() Thomas Gleixner
2022-04-15 12:07 ` Peter Zijlstra
2022-04-15 21:46 ` Thomas Gleixner
2022-05-02 12:04 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2022-04-15 9:19 ` [patch 2/3] timekeeping: Mark tk_clock_read() __always_inline Thomas Gleixner
2022-04-15 12:09 ` Peter Zijlstra [this message]
2022-04-15 21:48 ` Thomas Gleixner
2022-04-15 9:19 ` [patch 3/3] timekeeping: Consolidate fast timekeeper Thomas Gleixner
2022-04-15 12:09 ` Peter Zijlstra
2022-05-02 12:04 ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YllgYuZ2jJvQbfZo@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox