From: Liam Beguin <liambeguin@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Peter Rosin <peda@axentia.se>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: afe: rescale: Make use of device properties
Date: Fri, 15 Apr 2022 10:47:23 -0400 [thread overview]
Message-ID: <YlmFezCYNeUxa8cL@shaak> (raw)
In-Reply-To: <YlhT/yiJSD7pFsF8@smile.fi.intel.com>
On Thu, Apr 14, 2022 at 08:03:59PM +0300, Andy Shevchenko wrote:
> On Thu, Apr 14, 2022 at 10:32:38AM -0400, Liam Beguin wrote:
> > Hi Andy,
> >
> > On Wed, Apr 13, 2022 at 10:01:17PM +0300, Andy Shevchenko wrote:
> > > Convert the module to be property provider agnostic and allow
> > > it to be used on non-OF platforms.
>
> > > +#include <linux/mod_devicetable.h>
> >
> > Is this really needed?
>
> Yes.
> This header is missed. I can split its addition to a separate patch.
Understood, maybe a separate patch would make it more explicit.
Cheers,
Liam
> > device_get_match_data() is already defined in <linux/property.h>
>
> It's indirectly related (just like we do when we clean up of.h). Since
> the original of.h is missed there is no header replacement, just adding.
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2022-04-15 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-13 19:01 [PATCH v1 1/1] iio: afe: rescale: Make use of device properties Andy Shevchenko
2022-04-14 14:32 ` Liam Beguin
2022-04-14 17:03 ` Andy Shevchenko
2022-04-15 14:47 ` Liam Beguin [this message]
2022-04-16 10:41 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlmFezCYNeUxa8cL@shaak \
--to=liambeguin@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox