From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97DC1C433FE for ; Sun, 17 Apr 2022 08:51:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233717AbiDQIxf (ORCPT ); Sun, 17 Apr 2022 04:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231579AbiDQIxd (ORCPT ); Sun, 17 Apr 2022 04:53:33 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F10621A388 for ; Sun, 17 Apr 2022 01:50:58 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B3C3B808C0 for ; Sun, 17 Apr 2022 08:50:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50D38C385A4; Sun, 17 Apr 2022 08:50:54 +0000 (UTC) Date: Sun, 17 Apr 2022 09:50:50 +0100 From: Catalin Marinas To: Herbert Xu Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" Subject: Re: [PATCH 07/10] crypto: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 17, 2022 at 04:35:58PM +0800, Herbert Xu wrote: > On Sun, Apr 17, 2022 at 09:31:09AM +0100, Catalin Marinas wrote: > > > > Not with my series, the non-sharing of cache lines is preserved. > > kmalloc() still returns objects aligned to a cache-line. > > ARCH_DMA_MINALIGN was chosen as the cover-all value for all SoCs > > supported but I want to reduce the kmalloc() alignment to a cache line > > size if a platform has a cache line smaller than ARCH_DMA_MINALIGN (most > > arm64 SoCs have a cache line of 64 bytes rather than 128). > > OK, but then you don't need to play with CRYPTO_MINALIGN at all, > right? All you need to do is add the padding between the Crypto > API fields and the context structure, right? Right, if that's what you prefer. Something like: diff --git a/include/linux/crypto.h b/include/linux/crypto.h index 2324ab6f1846..bb645b2f2718 100644 --- a/include/linux/crypto.h +++ b/include/linux/crypto.h @@ -645,7 +645,7 @@ struct crypto_tfm { struct crypto_alg *__crt_alg; - void *__crt_ctx[] CRYPTO_MINALIGN_ATTR; + void *__crt_ctx[] __aligned(ARCH_DMA_MINALIGN); }; But once we do that, are there any other CRYPTO_MINALIGN left around? -- Catalin