From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>,
linux-clk@vger.kernel.org, openbmc@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org,
devicetree@vger.kernel.org,
"Michael Turquette" <mturquette@baylibre.com>,
"Stephen Boyd" <sboyd@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Avi Fishman" <avifishman70@gmail.com>,
"Tomer Maimon" <tmaimon77@gmail.com>,
"Tali Perry" <tali.perry1@gmail.com>,
"Patrick Venture" <venture@google.com>,
"Nancy Yuen" <yuenn@google.com>,
"Benjamin Fair" <benjaminfair@google.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Wim Van Sebroeck" <wim@linux-watchdog.org>,
"Guenter Roeck" <linux@roeck-us.net>
Subject: Re: [PATCH v2 4/7] dt-bindings: clock: Add Nuvoton WPCM450 clock/reset controller
Date: Mon, 2 May 2022 17:04:47 +0200 [thread overview]
Message-ID: <Ym/zDx2PQfybo9mm@latitude> (raw)
In-Reply-To: <3c2f2e75-153b-05bf-9878-70fc1c1a81b1@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 669 bytes --]
On Sun, May 01, 2022 at 10:55:37AM +0200, Krzysztof Kozlowski wrote:
> On 29/04/2022 19:20, Jonathan Neuschäfer wrote:
> > The Nuvoton WPCM450 SoC has a combined clock and reset controller.
> > Add a devicetree binding for it, as well as definitions for the bit
> > numbers used by it.
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
> > ---
[...]
> > + clock-names:
> > + items:
> > + - const: refclk
>
> Sorry for not bringing it up earlier - this should be just "ref". Names
> in values should not have suffixes (so no "tx-dma", "wake-gpio",
> "ref-clk" etc).
Ok, I'll fix it throughout the patchset.
Jonathan
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-02 15:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 17:20 [PATCH v2 0/7] Nuvoton WPCM450 clock and reset driver Jonathan Neuschäfer
2022-04-29 17:20 ` [PATCH v2 1/7] dt-bindings: timer: nuvoton,npcm7xx-timer: Allow specifying all clocks Jonathan Neuschäfer
2022-05-04 20:34 ` Rob Herring
2022-04-29 17:20 ` [PATCH v2 2/7] clocksource: timer-npcm7xx: Enable timer 1 clock before use Jonathan Neuschäfer
2022-04-29 17:20 ` [PATCH v2 3/7] watchdog: npcm: Enable clock if provided Jonathan Neuschäfer
2022-04-29 17:42 ` Guenter Roeck
2022-04-29 17:20 ` [PATCH v2 4/7] dt-bindings: clock: Add Nuvoton WPCM450 clock/reset controller Jonathan Neuschäfer
2022-05-01 8:55 ` Krzysztof Kozlowski
2022-05-02 15:04 ` Jonathan Neuschäfer [this message]
2022-04-29 17:20 ` [PATCH v2 5/7] ARM: dts: wpcm450: Add clock controller node Jonathan Neuschäfer
2022-04-29 17:20 ` [PATCH v2 6/7] clk: wpcm450: Add Nuvoton WPCM450 clock/reset controller driver Jonathan Neuschäfer
2022-04-29 17:20 ` [PATCH v2 7/7] ARM: dts: wpcm450: Switch clocks to clock controller Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ym/zDx2PQfybo9mm@latitude \
--to=j.neuschaefer@gmx.net \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mturquette@baylibre.com \
--cc=openbmc@lists.ozlabs.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tglx@linutronix.de \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=wim@linux-watchdog.org \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox