From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
Cc: mchehab@kernel.org, sakari.ailus@linux.intel.com,
hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: i2c: ov5645: Remove unneeded of_match_ptr macro
Date: Mon, 2 May 2022 01:59:57 +0300 [thread overview]
Message-ID: <Ym8Q7QhoT2aqMrJr@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20220429222754.11333-1-mosescb.dev@gmail.com>
Hi Moses,
Thank you for the patch.
On Sat, Apr 30, 2022 at 12:27:54AM +0200, Moses Christopher Bollavarapu wrote:
> of_match_ptr isn't required as CONFIG_OF is already a dependency in Kconfig
And the .of_match_table field hasn't been conditional on CONFIG_OF for a
long time now.
> Signed-off-by: Moses Christopher Bollavarapu <mosescb.dev@gmail.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/ov5645.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov5645.c b/drivers/media/i2c/ov5645.c
> index 368fa21e675e..ea73c060514d 100644
> --- a/drivers/media/i2c/ov5645.c
> +++ b/drivers/media/i2c/ov5645.c
> @@ -1283,7 +1283,7 @@ MODULE_DEVICE_TABLE(of, ov5645_of_match);
>
> static struct i2c_driver ov5645_i2c_driver = {
> .driver = {
> - .of_match_table = of_match_ptr(ov5645_of_match),
> + .of_match_table = ov5645_of_match,
> .name = "ov5645",
> },
> .probe_new = ov5645_probe,
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2022-05-01 23:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 22:27 [PATCH] media: i2c: ov5645: Remove unneeded of_match_ptr macro Moses Christopher Bollavarapu
2022-05-01 22:59 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ym8Q7QhoT2aqMrJr@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mosescb.dev@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox