Re: [PATCH v2 3/8] dt-bindings: PCI: renesas-pci-usb: Allow multiple clocks

Herve Codina
2022-04-20T14:55:41Z

Hi Rob, Geert,

On Wed, 20 Apr 2022 08:24:59 -0500
Rob Herring <robh@kernel.org> wrote:

...
> > Is there a way to have the clocks description depending on the compatible value.
> > I mean something like:
> > --- 8< ---
> > properties:
> > clocks:
> > maxItems: 1
>
> This would need to cover both cases:
>
> minItems: 1
> maxItems: 3
>
> >
> > if:
> > properties:
> > compatible:
> > contains:
> > enum:
> > - renesas,pci-r9a06g032
> > - renesas,pci-rzn1
> >
> > then:
> > properties:
> > clocks:
> > items:
> > - description: Internal bus clock (AHB) for HOST
> > - description: Internal bus clock (AHB) Power Management
> > - description: PCI clock for USB subsystem
> > minItems: 3
> > maxItems: 3
>
> Don't need minItems or maxItems here. 3 is the default size based on
> 'items' length.
>
> >
> > else:
> > properties:
> > items:
>
> I think you meant for this to be under 'clocks'.
>
> > - description: Device clock
> > clocks:
> > minItems: 1
> > maxItems: 1
>
> Just 'maxItems' is enough.
>
> > --- 8< ---
> >

Thanks to your details and Geert's binding examples,

I have the clocks description and clock-names set depending
on compatible value.

This will be present in v3 series.

Regards,
Hervé

--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering