From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH] f2fs: use flush command instead of FUA for zoned device
Date: Wed, 20 Apr 2022 11:12:00 -0700 [thread overview]
Message-ID: <YmBM8KEZ9JttevxH@google.com> (raw)
In-Reply-To: <Yl+XIjiuFRN9Pzxv@infradead.org>
On 04/19, Christoph Hellwig wrote:
> On Tue, Apr 19, 2022 at 02:57:03PM -0700, Jaegeuk Kim wrote:
> > The block layer for zoned disk can reorder the FUA'ed IOs. Let's use flush
> > command to keep the write order.
>
> The block layer can reorder all commands. Given that FUA only affects
> the command itself that should not matter. What is this trying to fix?
Not for zoned disk, as I mentioned. The mq-deadline serializes write commands
but I got an reordered command, if there's a FUA|PREFLUSH command, which emits
EIO by the disk.
next prev parent reply other threads:[~2022-04-20 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-19 21:57 [PATCH] f2fs: use flush command instead of FUA for zoned device Jaegeuk Kim
2022-04-20 5:16 ` Christoph Hellwig
2022-04-20 18:12 ` Jaegeuk Kim [this message]
2022-04-21 8:43 ` Damien Le Moal
2022-04-21 15:20 ` Jaegeuk Kim
2022-04-21 16:05 ` [PATCH v2] " Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmBM8KEZ9JttevxH@google.com \
--to=jaegeuk@kernel.org \
--cc=hch@infradead.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox