From: Eric Biggers <ebiggers@kernel.org>
To: syzbot <syzbot+1a748d0007eeac3ab079@syzkaller.appspotmail.com>
Cc: jaegeuk@kernel.org, linux-fscrypt@vger.kernel.org,
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com,
tytso@mit.edu, linux-ext4@vger.kernel.org
Subject: Re: [syzbot] possible deadlock in fscrypt_initialize
Date: Thu, 21 Apr 2022 01:42:18 +0000 [thread overview]
Message-ID: <YmC2epeJNChYxWB3@gmail.com> (raw)
In-Reply-To: <00000000000070395e05dd1fb4d7@google.com>
On Wed, Apr 20, 2022 at 06:05:24PM -0700, syzbot wrote:
> Hello,
>
> syzbot found the following issue on:
>
> HEAD commit: 90ea17a9e27b Merge tag 'scsi-fixes' of git://git.kernel.or..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/log.txt?x=16bf09d0f00000
> kernel config: https://syzkaller.appspot.com/x/.config?x=ac042ae170e2c50f
> dashboard link: https://syzkaller.appspot.com/bug?extid=1a748d0007eeac3ab079
> compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2
>
> Unfortunately, I don't have any reproducer for this issue yet.
>
> IMPORTANT: if you fix the issue, please add the following tag to the commit:
> Reported-by: syzbot+1a748d0007eeac3ab079@syzkaller.appspotmail.com
>
> ======================================================
> WARNING: possible circular locking dependency detected
> 5.18.0-rc2-syzkaller-00291-g90ea17a9e27b #0 Not tainted
> ------------------------------------------------------
> syz-executor.0/3694 is trying to acquire lock:
> ffffffff8bf36428 (fscrypt_init_mutex){+.+.}-{3:3}, at: fscrypt_initialize+0x3c/0xa0 fs/crypto/crypto.c:324
>
> but task is already holding lock:
> ffff8880430c8990 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0xfb4/0x14a0 fs/jbd2/transaction.c:461
This is a regression from a while back from the ext4 fast_commit changes,
specifically commit a80f7fcf1867 ("ext4: fixup ext4_fc_track_* functions'
signature") which extended the scope of the transaction in ext4_unlink() too
far. It's been on my TODO list to fix, along with the reports of fast_commit
and encryption not working together. I'll try to get to it soon.
- Eric
prev parent reply other threads:[~2022-04-21 1:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 1:05 [syzbot] possible deadlock in fscrypt_initialize syzbot
2022-04-21 1:42 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmC2epeJNChYxWB3@gmail.com \
--to=ebiggers@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzbot+1a748d0007eeac3ab079@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox