From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0C0FC433F5 for ; Thu, 21 Apr 2022 17:11:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352707AbiDUROB (ORCPT ); Thu, 21 Apr 2022 13:14:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231312AbiDURN4 (ORCPT ); Thu, 21 Apr 2022 13:13:56 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8331B49F06 for ; Thu, 21 Apr 2022 10:11:06 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id ga4-20020a17090b038400b001d4b33c74ccso4416026pjb.1 for ; Thu, 21 Apr 2022 10:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=b7HyC84YWaJi+rFPuVcTNleREIonvKxhwkU7uOpi5IA=; b=SK7jNRDR4Faawnn1rRV1m39m9ZMGdD9pQ6fLRLba7dWPyOzfrZHcGu6vCox7BixDVH hzWH97436KUkp5rH4s+5vhRvUSu76Qg/0hEt6Vb3BQAaCCuI8/x2Sr+D3168/mv5cdk7 wzUZVe2GtEPzPIGK1ZQ75HS1g0c1vQBEFRF2M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=b7HyC84YWaJi+rFPuVcTNleREIonvKxhwkU7uOpi5IA=; b=hdQsYFz9NwRKZOR7XeeBBR62seZ50gGZ0SIN7voZQEsDOT80nQVDy6W8sCiPJKVlP8 m+O8hLmv76OZPf7sKZNLawPuZbDS92WYGYUBNlaFTykd5CQWghQtnR2z0PcBmQevAaMw KmYWL+sU7Ahh0GnbNxl/7w2uCFtm4eByQ4vJRm9QRD4KvhnUQ/pqNfC6fW6H66kGf6MF qPobDETtVtmT7oXk5nYJJkExi/1bPJd9n1W9ZCLHeq0bAKP2GEAP1NPFJAzUO0SqzoSe wYZe+nb1/7Vv5vVhRpS5zRHKwzHtu6nMlfFMqrMFZYcxmtQyc9O/u6OQ/U1p4gtAxWjr 9bcw== X-Gm-Message-State: AOAM531TRGczBwv1o2BBidy0kmjLK7xobvcvd+CMA5pErJIXAHy/hoT0 YaxOlikhtXXvq3vdUerc3RNalg== X-Google-Smtp-Source: ABdhPJzpa34oFn2IWGqz+K+ssfPq9d/6lYrTylDwIjezAJ6Tc35d0NdLgGzlFyU+LIMwrX/VDY7XGA== X-Received: by 2002:a17:90a:a593:b0:1c9:b837:e77d with SMTP id b19-20020a17090aa59300b001c9b837e77dmr626226pjq.205.1650561066073; Thu, 21 Apr 2022 10:11:06 -0700 (PDT) Received: from localhost ([2620:15c:202:201:d426:5807:a72:7b27]) by smtp.gmail.com with UTF8SMTPSA id y17-20020a17090a8b1100b001cd4989fee5sm3370709pjn.49.2022.04.21.10.11.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 10:11:05 -0700 (PDT) Date: Thu, 21 Apr 2022 10:11:04 -0700 From: Matthias Kaehlcke To: Srinivasa Rao Mandadapu Cc: agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, quic_rohkumar@quicinc.com, srinivas.kandagatla@linaro.org, dianders@chromium.org, swboyd@chromium.org, judyhsiao@chromium.org, Venkata Prasad Potturu Subject: Re: [PATCH v9 07/12] arm64: dts: qcom: sc7280: Add max98360a codec node for CRD 3.0/3.1 Message-ID: References: <1650552459-21077-1-git-send-email-quic_srivasam@quicinc.com> <1650552459-21077-8-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1650552459-21077-8-git-send-email-quic_srivasam@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 21, 2022 at 08:17:34PM +0530, Srinivasa Rao Mandadapu wrote: > Subject: arm64: dts: qcom: sc7280: Add max98360a codec node for CRD 3.0/3.1 This isn´t limited to the CRD 3.x, but applies to all herobrine boards, so it should be something like "arm64: dts: qcom: sc7280: herobrine: Add max98360a codec". > Add max98360a codec node for audio use case on CRD rev5 > (aka CRD 3.0/3.1) boards. ditto > Signed-off-by: Srinivasa Rao Mandadapu > Co-developed-by: Venkata Prasad Potturu > Signed-off-by: Venkata Prasad Potturu > --- > arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > index d58045d..f247403 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi > @@ -20,6 +20,14 @@ > #include "sc7280-chrome-common.dtsi" > > / { > + max98360a: audio-codec-0 { > + compatible = "maxim,max98360a"; > + pinctrl-names = "default"; > + pinctrl-0 = <&_en>; > + sdmode-gpios = <&tlmm 63 GPIO_ACTIVE_HIGH>; > + #sound-dai-cells = <0>; > + }; > + This node should be added before 'pwmleds' (alphabetical order within the board-specific top level nodes). > chosen { > stdout-path = "serial0:115200n8"; > }; > -- > 2.7.4 >