From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7583FC433EF for ; Thu, 21 Apr 2022 18:13:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1388386AbiDUSQE (ORCPT ); Thu, 21 Apr 2022 14:16:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41206 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236260AbiDUSQB (ORCPT ); Thu, 21 Apr 2022 14:16:01 -0400 Received: from mail-pl1-x62a.google.com (mail-pl1-x62a.google.com [IPv6:2607:f8b0:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DE884AE38 for ; Thu, 21 Apr 2022 11:13:11 -0700 (PDT) Received: by mail-pl1-x62a.google.com with SMTP id c23so5641230plo.0 for ; Thu, 21 Apr 2022 11:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=lJhN1mtetWtoQcGidNztP52TwkjHuAbhYwhXQGMD9XQ=; b=aFZ1JRqXlPDvW0SAlxaHHiQdk3oRabw71YHdDlJhFsrxiGA6U4Mw9RdMR6DAXWcLVf +ObfpbrbDez3ZtNYKvQ5ud1sH7rr10JnejK0wu5p0gCb7tTOZskJOtJZDL4c5fySz5KH HH+L+vtSiEDgBfrNwftw2LTpbQ/rRwBdOsQcw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=lJhN1mtetWtoQcGidNztP52TwkjHuAbhYwhXQGMD9XQ=; b=gKuG617TRF3vAX9CAcCvwM1NxsB6FYd78e7Zo7qAZTUe4BZz6uIEqFD+9nKsGjeTkr B1KTwHGhAIzZThRuev+gxG08YCRElPOpgp+OKg9kRG5T6Euc8+gEzVigRpOfyBbArTU4 8mRYJtZCP4kfBWKgbIRyjv0PB6VHrsvJ0fJpi1nYTPv5JUNUGD0GbNGY8dPF+sMaEQ9j gMiJxT/ETVxTxPpa9hwEeqRp8ux39wsxU32MBozRKSY33FdZlCmHJ1KL3ksqpkF+R/Z9 UqejQPymCjZXjogMmuCEzYMh/84+aRkG7tnEgnVK86b5R9kDAUGcOa4N5qQ1/skOYpFS zWSA== X-Gm-Message-State: AOAM533D6q0itO8AEvP2Kd0qquNwAccd17jbRbN1EFuROwTV/T/C5r2Y TYsjLeTrfPJuZ/nhmSsqKl0suA== X-Google-Smtp-Source: ABdhPJx4vtQYv7ivk8pmhwD7P8ioY0zapzr/HTW7kdNOUbKpPJYVldebkDVUrO5e2cpLBCiMsmB2Fw== X-Received: by 2002:a17:90a:8a04:b0:1d5:d64f:a1e5 with SMTP id w4-20020a17090a8a0400b001d5d64fa1e5mr5396855pjn.109.1650564790608; Thu, 21 Apr 2022 11:13:10 -0700 (PDT) Received: from localhost ([2620:15c:202:201:d426:5807:a72:7b27]) by smtp.gmail.com with UTF8SMTPSA id d206-20020a621dd7000000b0050acf2c1303sm5839273pfd.107.2022.04.21.11.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 11:13:10 -0700 (PDT) Date: Thu, 21 Apr 2022 11:13:08 -0700 From: Matthias Kaehlcke To: Doug Anderson Cc: Greg Kroah-Hartman , Alan Stern , Rob Herring , Frank Rowand , Mathias Nyman , Felipe Balbi , Linux USB List , Ravi Chandra Sadineni , Roger Quadros , LKML , Bastien Nocera , Michal Simek , Stephen Boyd , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Krzysztof Kozlowski , Peter Chen , Guo Zhengkui , Kishon Vijay Abraham I , Li Jun , Peter Chen , Thinh Nguyen Subject: Re: [PATCH v21 0/3] usb: misc: Add onboard_usb_hub driver Message-ID: References: <20220217184254.4141705-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Thu, Apr 07, 2022 at 12:41:22PM -0700, Doug Anderson wrote: > Hi, > > On Thu, Feb 17, 2022 at 10:43 AM Matthias Kaehlcke wrote: > > > > This series adds: > > - the onboard_usb_hub_driver > > - glue in the generic HCD code to create and destroy the > > onboard_usb_hub platform devices if needed > > - device tree changes that add RTS5411 entries for the QCA SC7180 > > based boards trogdor and lazor > > - a couple of stubs for platform device functions to avoid > > unresolved symbols with certain kernel configs > > > > The main issue the driver addresses is that a USB hub needs to be > > powered before it can be discovered. For discrete onboard hubs (an > > example for such a hub is the Realtek RTS5411) this is often solved > > by supplying the hub with an 'always-on' regulator, which is kind > > of a hack. Some onboard hubs may require further initialization > > steps, like changing the state of a GPIO or enabling a clock, which > > requires even more hacks. This driver creates a platform device > > representing the hub which performs the necessary initialization. > > Currently it only supports switching on a single regulator, support > > for multiple regulators or other actions can be added as needed. > > Different initialization sequences can be supported based on the > > compatible string. > > > > Besides performing the initialization the driver can be configured > > to power the hub off during system suspend. This can help to extend > > battery life on battery powered devices which have no requirements > > to keep the hub powered during suspend. The driver can also be > > configured to leave the hub powered when a wakeup capable USB device > > is connected when suspending, and power it off otherwise. > > > > Changes in v21: > > - dropped patch 'driver core: Export device_is_bound()' > > - refactored _find_onboard_hub() > > - removed 'onboard_hub_dev' symlinks from USB devices > > - dropped patch 'arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub' > > (will be sent separately) > > - rebased series on v5.17-rc4 > > > > Changes in v20: > > - addressed review comments from Stephen > > - changed DT node names for hubs > > > > Changes in v19: > > - added VID:PID pairs and compatible strings for RTS5414 hub > > - updated comments with RTS5411 USB versions to reflect those > > reported/supported by the hub > > - rebased series on v5.16 > > > > Changes in v18: > > - introduced hidden Kconfig option to align module vs. builtin > > choice with CONFIG_USB (thanks Doug!) > > - added patch 'driver core: Export device_is_bound()' > > - also adjust device tree of pompom rev1 > > - dropped the following patches, which aren't needed anymore by this > > series (though they might still be useful on their own): > > - usb: Specify dependencies on USB_XHCI_PLATFORM with 'depends on' > > - arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM > > - ARM: configs: Explicitly enable USB_XHCI_PLATFORM where needed > > > > Changes in v17: > > - rebased on top of v5.16-rc1 > > - moved creation of onboard_hub platform devices from xhci_platform > > to the generic HCD code > > - addressed review comments for the onboard_hub driver > > - moved Kconfig/defconfig changes to the end of the series. The > > onboard_hub driver doesn't depend on XHCI_PLATFORM anymore, > > hence these changes aren't really required for the driver, but > > they still seem to be a worthwhile improvement > > > > Changes in v16: > > - added patch 'ARM: configs: Explicitly enable USB_XHCI_PLATFORM > > where needed' to keep arm32 defconfigs effectively unchanged > > > > Changes in v15: > > - adjusted dependencies of USB_DWC3_CORE to make sure it can only > > be enabled when at least one of USB_DWC3_HOST, USB_DWC3_GADGET > > or USB_DWC3_DUAL_ROLE is selectable > > > > Changes in v14: > > - rebased on top of v5.14-rc1 > > - dropped DT binding patch which landed in v5.13 > > > > Changes in v13: > > - added patch "usb: Specify dependency on USB_XHCI_PLATFORM with > > 'depends on'" to the series to avoid Kconfig conflicts > > - added patch "arm64: defconfig: Explicitly enable USB_XHCI_PLATFORM" > > to the series to keep effective defconfig unchanged > > > > Changes in v12: > > - onboard_hub driver: use IS_ENABLED(CONFIG_USB_ONBOARD_HUB_MODULE) > > in onboard_hub.h to also check for the driver built as module > > - onboard_hub_driver: include onboard_hub.h again to make sure there > > are prototype declarations for the public functions > > > > Changes in v11: > > - support multiple onboard hubs connected to the same parent > > - don't include ‘onboard_hub.h’ from the onboard hub driver > > > > Changes in v10: > > - always use of_is_onboard_usb_hub() stub unless ONBOARD_USB_HUB=y/m > > - keep 'regulator-boot-on' property for pp3300_hub > > > > Changes in v9: > > - added dependency on ONBOARD_USB_HUB (or !ONBOARD_USB_HUB) to > > USB_PLATFORM_XHCI > > > > Changes in v7: > > - updated DT binding > > - series rebased on qcom/arm64-for-5.13 > > > > Changes in v6: > > - updated summary > > > > Changes in v5: > > - cover letter added > > > > Matthias Kaehlcke (3): > > of/platform: Add stubs for of_platform_device_create/destroy() > > usb: misc: Add onboard_usb_hub driver > > usb: core: hcd: Create platform devices for onboard hubs in probe() > > > > .../sysfs-bus-platform-onboard-usb-hub | 8 + > > MAINTAINERS | 7 + > > drivers/usb/core/hcd.c | 6 + > > drivers/usb/misc/Kconfig | 23 + > > drivers/usb/misc/Makefile | 1 + > > drivers/usb/misc/onboard_usb_hub.c | 510 ++++++++++++++++++ > > include/linux/of_platform.h | 22 +- > > include/linux/usb/hcd.h | 1 + > > include/linux/usb/onboard_hub.h | 18 + > > 9 files changed, 592 insertions(+), 4 deletions(-) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-platform-onboard-usb-hub > > create mode 100644 drivers/usb/misc/onboard_usb_hub.c > > create mode 100644 include/linux/usb/onboard_hub.h > > With v5.18-rc1 out the door, I wonder if it's a good time to look at > this series again. Are there any hidden blockers that it's waiting > for? Greg, please let me know if any further changes are needed or if this series can be landed.