From: Greg KH <gregkh@linuxfoundation.org>
To: Jaehee Park <jhpark1013@gmail.com>
Cc: Larry.Finger@lwfinger.net, phil@philpotter.co.uk,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
outreachy@lists.linux.dev, Pavel Skripkin <paskripkin@gmail.com>
Subject: Re: [PATCH v4 7/7] staging: r8188eu: remove unused else condition
Date: Fri, 22 Apr 2022 16:45:55 +0200 [thread overview]
Message-ID: <YmK/o23YIeXwKlep@kroah.com> (raw)
In-Reply-To: <bba338ae5f9992dbf2a64b388f7702e6b287d8c2.1650568579.git.jhpark1013@gmail.com>
On Thu, Apr 21, 2022 at 03:20:32PM -0400, Jaehee Park wrote:
> s_ret cannot return '2' so this else condition is unused. Remove this
> unnecessary else statement.
s_ret is not a function, it is a value.
rtw_select_and_join_from_scanned_queue() is the function here.
Can you fix up the wording in this changelog text and resubmit?
thanks,
greg k-h
next prev parent reply other threads:[~2022-04-22 14:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 19:20 [PATCH v4 0/7] staging: r8188eu: fix warnings reported by checkpatch Jaehee Park
2022-04-21 19:20 ` [PATCH v4 1/7] staging: r8188eu: remove unnecessary braces in single statement block Jaehee Park
2022-04-21 19:52 ` Fabio M. De Francesco
2022-04-21 23:20 ` Fabio M. De Francesco
2022-04-21 19:20 ` [PATCH v4 2/7] staging: r8188eu: remove spaces before tabs Jaehee Park
2022-04-21 19:20 ` [PATCH v4 3/7] staging: r8188eu: remove 'added by' author comments Jaehee Park
2022-04-21 19:20 ` [PATCH v4 4/7] staging: r8188eu: place constants on the right side of tests Jaehee Park
2022-04-21 19:20 ` [PATCH v4 5/7] staging: r8188eu: replace spaces with tabs Jaehee Park
2022-04-21 19:20 ` [PATCH v4 6/7] staging: r8188eu: correct typo in comments Jaehee Park
2022-04-21 19:20 ` [PATCH v4 7/7] staging: r8188eu: remove unused else condition Jaehee Park
2022-04-22 14:45 ` Greg KH [this message]
2022-04-27 15:37 ` Jaehee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmK/o23YIeXwKlep@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Larry.Finger@lwfinger.net \
--cc=jhpark1013@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=paskripkin@gmail.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox