The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Martin Povišer" <povik@cutebit.org>
Cc: "Martin Povišer" <povik+lin@cutebit.org>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>,
	alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Mark Kettenis" <kettenis@openbsd.org>,
	"Hector Martin" <marcan@marcan.st>,
	"Sven Peter" <sven@svenpeter.dev>
Subject: Re: [RFC PATCH 0/5] Apple Macs machine-level ASoC driver
Date: Fri, 22 Apr 2022 13:44:31 +0100	[thread overview]
Message-ID: <YmKjL9bOtOmsFWTs@sirena.org.uk> (raw)
In-Reply-To: <6F6130F3-381C-4AB7-B618-CDC4C4A37C9B@cutebit.org>

[-- Attachment #1: Type: text/plain, Size: 1045 bytes --]

On Fri, Apr 22, 2022 at 02:36:03PM +0200, Martin Povišer wrote:

> > Ah, I think the confusion here is that I'm using slot and channel
> > interchangably whereas you're saying that previously the driver would
> > allocate two channels to each speaker with duplicate data?

> I guess you could say that. Not that there’s duplicate data on the I2S
> bus, but the speaker amp would previously be configured to look for the
> left and right channel in the same TDM slot (see e.g. set_tdm_slot of
> tas2770 [0]).  (Each speaker amp drives a single speaker, but it still
> has a notion of left and right channel.)

Oh, I see - the speaker actually allows configuration of the slots
independently.  Usually the left/right thing on mono devices only does
something for I2S where the bus clocking enforces that there be both
left and right channels.  Either configuration is fine by me TBH, if you
can do that then you could just keep them mapped to the same channel
then mark the control as disabled since it should have no effect.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2022-04-22 12:44 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-31  0:04 [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Martin Povišer
2022-03-31  0:04 ` [RFC PATCH 1/5] dt-bindings: sound: Add Apple Macs sound system Martin Povišer
2022-03-31  6:43   ` Krzysztof Kozlowski
2022-03-31  6:57     ` Martin Povišer
2022-03-31  8:17       ` Krzysztof Kozlowski
2022-03-31  8:23         ` Martin Povišer
2022-03-31  8:26           ` Krzysztof Kozlowski
2022-03-31  0:04 ` [RFC PATCH 2/5] HACK: ASoC: Add card->filter_controls hook Martin Povišer
2022-03-31 11:34   ` Mark Brown
2022-03-31  0:04 ` [RFC PATCH 3/5] HACK: ASoC: Tolerate N-cpus-to-M-codecs links Martin Povišer
2022-04-04 12:28   ` Mark Brown
2022-04-22 14:06     ` Martin Povišer
2022-04-25 12:25       ` Mark Brown
2022-04-25 12:34         ` Martin Povišer
2022-04-25 12:55           ` Mark Brown
2022-04-25 13:11             ` Martin Povišer
2022-04-25 13:46               ` Mark Brown
2022-04-25 13:55                 ` Martin Povišer
2022-03-31  0:04 ` [RFC PATCH 4/5] ASoC: Introduce snd_soc_of_get_dai_link_cpus Martin Povišer
2022-03-31  0:04 ` [RFC PATCH 5/5] ASoC: Add macaudio machine driver Martin Povišer
2022-03-31 11:59   ` Mark Brown
2022-03-31 12:08     ` Martin Povišer
2022-03-31 12:16       ` Martin Povišer
2022-03-31 12:56       ` Mark Brown
2022-03-31 12:34 ` [RFC PATCH 0/5] Apple Macs machine-level ASoC driver Mark Brown
2022-03-31 13:28   ` Martin Povišer
2022-03-31 14:18     ` Mark Brown
2022-03-31 15:04       ` Martin Povišer
2022-03-31 15:36         ` Mark Brown
2022-04-22 10:43           ` Martin Povišer
2022-04-22 11:19             ` Mark Brown
2022-04-22 11:28               ` Martin Povišer
2022-04-22 11:33                 ` Mark Brown
2022-04-22 11:44                   ` Martin Povišer
2022-04-22 12:22                     ` Mark Brown
2022-04-22 12:36                       ` Martin Povišer
2022-04-22 12:44                         ` Mark Brown [this message]
2022-04-22 12:53                           ` Martin Povišer
2022-04-22 13:06                             ` Mark Brown
2022-04-22 13:59                               ` Martin Povišer
2022-03-31 13:28   ` Hector Martin
2022-03-31 14:33     ` Mark Brown
2022-04-05  9:31 ` (subset) " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmKjL9bOtOmsFWTs@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kettenis@openbsd.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcan@marcan.st \
    --cc=perex@perex.cz \
    --cc=povik+lin@cutebit.org \
    --cc=povik@cutebit.org \
    --cc=robh+dt@kernel.org \
    --cc=sven@svenpeter.dev \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox