From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: martin.petersen@oracle.com, jejb@linux.ibm.com,
avri.altman@wdc.com, alim.akhtar@samsung.com,
linux-arm-msm@vger.kernel.org, quic_asutoshd@quicinc.com,
quic_cang@quicinc.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, bvanassche@acm.org,
ahalaney@redhat.com
Subject: Re: [PATCH v2 5/5] scsi: ufs: qcom: Enable RPM_AUTOSUSPEND for runtime PM
Date: Sat, 23 Apr 2022 08:20:01 -0700 [thread overview]
Message-ID: <YmQZIeA3xBHfudmf@ripper> (raw)
In-Reply-To: <20220423140245.394092-6-manivannan.sadhasivam@linaro.org>
On Sat 23 Apr 07:02 PDT 2022, Manivannan Sadhasivam wrote:
> In order to allow the block devices to enter autosuspend mode during
> runtime, thereby allowing the ufshcd host driver to also runtime suspend,
> let's make use of the RPM_AUTOSUSPEND flag.
>
> Without this flag, userspace needs to enable the autosuspend feature of
> the block devices through sysfs.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> ---
> drivers/scsi/ufs/ufs-qcom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c
> index f47a16b7cff5..34c5970db445 100644
> --- a/drivers/scsi/ufs/ufs-qcom.c
> +++ b/drivers/scsi/ufs/ufs-qcom.c
> @@ -876,6 +876,7 @@ static void ufs_qcom_set_caps(struct ufs_hba *hba)
> hba->caps |= UFSHCD_CAP_WB_EN;
> hba->caps |= UFSHCD_CAP_CRYPTO;
> hba->caps |= UFSHCD_CAP_AGGR_POWER_COLLAPSE;
> + hba->caps |= UFSHCD_CAP_RPM_AUTOSUSPEND;
>
> if (host->hw_ver.major >= 0x2) {
> host->caps = UFS_QCOM_CAP_QUNIPRO |
> --
> 2.25.1
>
prev parent reply other threads:[~2022-04-23 15:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-23 14:02 [PATCH v2 0/5] Qcom UFS driver updates Manivannan Sadhasivam
2022-04-23 14:02 ` [PATCH v2 1/5] scsi: ufs: qcom: Fix acquiring the optional reset control line Manivannan Sadhasivam
2022-04-23 14:59 ` Bjorn Andersson
2022-04-25 12:59 ` Andrew Halaney
2022-04-23 14:02 ` [PATCH v2 2/5] scsi: ufs: qcom: Simplify handling of devm_phy_get() Manivannan Sadhasivam
2022-04-23 15:16 ` Bjorn Andersson
2022-04-25 13:01 ` Andrew Halaney
2022-04-23 14:02 ` [PATCH v2 3/5] scsi: ufs: qcom: Add a readl() to make sure ref_clk gets enabled Manivannan Sadhasivam
2022-04-23 15:18 ` Bjorn Andersson
2022-04-23 14:02 ` [PATCH v2 4/5] scsi: ufs: core: Remove redundant wmb() in ufshcd_send_command() Manivannan Sadhasivam
2022-04-23 15:19 ` Bjorn Andersson
2022-04-24 11:04 ` Bean Huo
2022-04-23 14:02 ` [PATCH v2 5/5] scsi: ufs: qcom: Enable RPM_AUTOSUSPEND for runtime PM Manivannan Sadhasivam
2022-04-23 15:20 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmQZIeA3xBHfudmf@ripper \
--to=bjorn.andersson@linaro.org \
--cc=ahalaney@redhat.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bvanassche@acm.org \
--cc=jejb@linux.ibm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=martin.petersen@oracle.com \
--cc=quic_asutoshd@quicinc.com \
--cc=quic_cang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox