From: Ira Weiny <ira.weiny@intel.com>
To: cgel.zte@gmail.com
Cc: dan.j.williams@intel.com, vishal.l.verma@intel.com,
dave.jiang@intel.com, ran.jianping@zte.com.cn,
jane.chu@oracle.com, rafael.j.wysocki@intel.com,
nvdimm@lists.linux.dev, linux-kernel@vger.kernel.org,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue
Date: Mon, 25 Apr 2022 08:07:43 -0700 [thread overview]
Message-ID: <Yma5P3b7HceTyUD6@iweiny-desk3> (raw)
In-Reply-To: <20220424062655.3221152-1-ran.jianping@zte.com.cn>
On Sun, Apr 24, 2022 at 06:26:55AM +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> tools/testing/nvdimm/test/nfit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
> index 1da76ccde448..e7e1a640e482 100644
> --- a/tools/testing/nvdimm/test/nfit.c
> +++ b/tools/testing/nvdimm/test/nfit.c
> @@ -3375,7 +3375,6 @@ static __exit void nfit_test_exit(void)
> {
> int i;
>
> - flush_workqueue(nfit_wq);
> destroy_workqueue(nfit_wq);
> for (i = 0; i < NUM_NFITS; i++)
> platform_device_unregister(&instances[i]->pdev);
> --
> 2.25.1
>
next prev parent reply other threads:[~2022-04-25 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 6:26 [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue cgel.zte
2022-04-25 15:07 ` Ira Weiny [this message]
2022-04-26 5:01 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yma5P3b7HceTyUD6@iweiny-desk3 \
--to=ira.weiny@intel.com \
--cc=cgel.zte@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=jane.chu@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=rafael.j.wysocki@intel.com \
--cc=ran.jianping@zte.com.cn \
--cc=vishal.l.verma@intel.com \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox