From: Mark Brown <broonie@kernel.org>
To: Stephen Kitt <steve@sk2.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Wolfram Sang <wsa@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 7/7] ASoC: tpa6130: use i2c_match_id and simple i2c probe
Date: Mon, 25 Apr 2022 14:26:50 +0100 [thread overview]
Message-ID: <YmahmnPi4B2n29BE@sirena.org.uk> (raw)
In-Reply-To: <20220415160613.148882-8-steve@sk2.org>
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
On Fri, Apr 15, 2022 at 06:06:13PM +0200, Stephen Kitt wrote:
> As part of the ongoing i2c transition to the simple probe
> ("probe_new"), this patch uses i2c_match_id to retrieve the
> driver_data for the probed device. The id parameter is thus no longer
> necessary and the simple probe can be used instead.
This breaks the build for omap2plus defconfig on arm:
/build/stage/linux/sound/soc/codecs/tpa6130a2.c:322:11: error: initialization of ‘int (*)(struct i2c_client *, const struct i2c_device_id *)’ from incompatible pointer type ‘int (*)(struct i2c_client *)’ [-Werror=incompatible-pointer-types]
322 | .probe = tpa6130a2_probe,
| ^~~~~~~~~~~~~~~
/build/stage/linux/sound/soc/codecs/tpa6130a2.c:322:11: note: (near initialization for ‘tpa6130a2_i2c_driver.probe’)
cc1: some warnings being treated as errors
You forgot to move probe() to probe_new() in the driver struct.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2022-04-25 13:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-15 16:06 [PATCH v2 0/7] ASoC: remaining i2c_match_id i2c probe changes Stephen Kitt
2022-04-15 16:06 ` [PATCH v2 1/7] ASoC: ak*: use i2c_match_id and simple i2c probe Stephen Kitt
2022-04-15 16:06 ` [PATCH v2 2/7] ASoC: alc56*: " Stephen Kitt
2022-04-15 16:06 ` [PATCH v2 3/7] ASoC: max980*: " Stephen Kitt
2022-04-15 16:06 ` [PATCH v2 4/7] ASoC: pcm186x: " Stephen Kitt
2022-04-15 16:06 ` [PATCH v2 5/7] ASoC: tas*: " Stephen Kitt
2022-04-15 16:06 ` [PATCH v2 6/7] ASoC: tlv320*: " Stephen Kitt
2022-04-15 16:06 ` [PATCH v2 7/7] ASoC: tpa6130: " Stephen Kitt
2022-04-25 13:26 ` Mark Brown [this message]
2022-05-01 17:08 ` Stephen Kitt
2022-04-25 17:24 ` [PATCH v2 0/7] ASoC: remaining i2c_match_id i2c probe changes Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmahmnPi4B2n29BE@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=steve@sk2.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox