From: Rob Herring <robh@kernel.org>
To: frowand.list@gmail.com
Cc: linux-kernel@vger.kernel.org, Jan Kiszka <jan.kiszka@siemens.com>,
Slawomir Stepien <slawomir.stepien@nokia.com>,
devicetree@vger.kernel.org, Slawomir Stepien <sst@poczta.fm>,
Rob Herring <robh+dt@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
pantelis.antoniou@konsulko.com
Subject: Re: [PATCH v4 1/2] of: overlay: rename variables to be consistent
Date: Mon, 25 Apr 2022 10:56:04 -0500 [thread overview]
Message-ID: <YmbElDC2GBUNY1E+@robh.at.kernel.org> (raw)
In-Reply-To: <20220420222505.928492-2-frowand.list@gmail.com>
On Wed, 20 Apr 2022 17:25:04 -0500, frowand.list@gmail.com wrote:
> From: Frank Rowand <frank.rowand@sony.com>
>
> Variables change name across function calls when there is not a good
> reason to do so. Fix by changing "fdt" to "new_fdt" and "tree" to
> "overlay_root".
>
> The name disparity was confusing when creating the following commit.
> The name changes are in this separate commit to make review of the
> following commmit less complex.
>
> Signed-off-by: Frank Rowand <frank.rowand@sony.com>
>
> ---
> Changes since v3:
> - none
>
> Changes since v2:
> - use new variable name "overlay_root" instead of new variable
> new "overlay_tree"
>
> drivers/of/overlay.c | 94 ++++++++++++++++++++++----------------------
> 1 file changed, 47 insertions(+), 47 deletions(-)
>
Applied, thanks!
next prev parent reply other threads:[~2022-04-25 15:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-20 22:25 [PATCH v4 0/2] of: overlay: rework overlay apply and remove kfree()s frowand.list
2022-04-20 22:25 ` [PATCH v4 1/2] of: overlay: rename variables to be consistent frowand.list
2022-04-25 15:56 ` Rob Herring [this message]
2022-04-20 22:25 ` [PATCH v4 2/2] of: overlay: rework overlay apply and remove kfree()s frowand.list
2022-04-20 22:31 ` Frank Rowand
2022-04-25 15:56 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmbElDC2GBUNY1E+@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=geert+renesas@glider.be \
--cc=jan.kiszka@siemens.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=slawomir.stepien@nokia.com \
--cc=sst@poczta.fm \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox