From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD
Date: Tue, 26 Apr 2022 11:38:53 +0200 [thread overview]
Message-ID: <Yme9rVZfELAECY7Z@kroah.com> (raw)
In-Reply-To: <2a50f3e99b15db2100f93e1e1a2b5cbc13b82882.1650784817.git.philipp.g.hortmann@gmail.com>
On Sun, Apr 24, 2022 at 09:44:11AM +0200, Philipp Hortmann wrote:
> Replace macro MACvReadMIBCounter with VNSvInPortD.
> Last patch within this patch series will replace all macros
> VNSvInPortD with ioread32. The names of macros and the arguments
> use CamelCase which is not accepted by checkpatch.pl
No need to say "last patch" as that will not make sense when these are
in the tree, right?
>
> Since there are more than one checkpatch issue per line,
> more steps are rquired to fix.
This sentance also is not needed.
So the changelog can just say:
Replace macro MACvReadMIBCounter with VNSvInPortD and as it was
the only user, it can now be removed.
Same comments on the other changes in this series, but I did take the
first patch, it made sense on its own.
thanks,
greg k-h
next prev parent reply other threads:[~2022-04-26 10:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 7:44 [PATCH 0/5] staging: vt6655: Replace macro VNSvInPortW,D with ioread16,32() Philipp Hortmann
2022-04-24 7:44 ` [PATCH 1/5] staging: vt6655: Replace VNSvInPortW with ioread16 Philipp Hortmann
2022-04-24 7:44 ` [PATCH 2/5] staging: vt6655: Replace MACvReadMIBCounter with VNSvInPortD Philipp Hortmann
2022-04-26 9:38 ` Greg Kroah-Hartman [this message]
2022-04-24 7:44 ` [PATCH 3/5] staging: vt6655: Replace MACvReadISR " Philipp Hortmann
2022-04-24 7:44 ` [PATCH 4/5] staging: vt6655: Replace two VNSvInPortD with ioread64_lo_hi Philipp Hortmann
2022-04-24 11:27 ` kernel test robot
2022-04-24 14:40 ` kernel test robot
2022-04-26 9:31 ` Greg Kroah-Hartman
2022-04-24 7:44 ` [PATCH 5/5] staging: vt6655: Replace VNSvInPortD with ioread32 Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yme9rVZfELAECY7Z@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=forest@alittletooquiet.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox