From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F9BCC433F5 for ; Tue, 26 Apr 2022 08:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344145AbiDZIIp (ORCPT ); Tue, 26 Apr 2022 04:08:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232960AbiDZIIf (ORCPT ); Tue, 26 Apr 2022 04:08:35 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 94C29DF3B; Tue, 26 Apr 2022 01:05:26 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id A378580C0; Tue, 26 Apr 2022 08:02:23 +0000 (UTC) Date: Tue, 26 Apr 2022 11:05:23 +0300 From: Tony Lindgren To: Ren Yu Cc: aaro.koskinen@iki.fi, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, liqiong@nfschina.com, yuzhe@nfschina.com, Arnd Bergmann Subject: Re: [PATCH] plat-omap: check return value of ioremap() Message-ID: References: <20220425110845.415439-1-renyu@nfschina.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220425110845.415439-1-renyu@nfschina.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * Ren Yu [220425 11:08]: > When ioremap() failed,return err This file is no longer being used and getting removed in Linux next. See commit 7058e68c2fed ("ARM: omap: remove debug-leds driver"). Thanks, Tony > Signed-off-by: Ren Yu > --- > arch/arm/plat-omap/debug-leds.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm/plat-omap/debug-leds.c b/arch/arm/plat-omap/debug-leds.c > index 2b698d074874..bf5034e10f6e 100644 > --- a/arch/arm/plat-omap/debug-leds.c > +++ b/arch/arm/plat-omap/debug-leds.c > @@ -109,6 +109,9 @@ static int fpga_probe(struct platform_device *pdev) > return -ENODEV; > > fpga = ioremap(iomem->start, resource_size(iomem)); > + if (!fpga) > + return -ENOMEM; > + > writew_relaxed(0xff, &fpga->leds); > > for (i = 0; i < ARRAY_SIZE(dbg_leds); i++) { > -- > 2.25.1 >