Re: [PATCH v2] mfd: cros_ec_dev: Only register PCHG device if present

Daisuke Nojiri
2022-04-19T18:32:49Z

The patch v2 looks good to me.

On Tue, Apr 19, 2022 at 7:59 AM Prashant Malani <pmalani@chromium.org> wrote:
>
> On Tue, Apr 19, 2022 at 7:55 AM Stephen Boyd <swboyd@chromium.org> wrote:
> >
> > Quoting Prashant Malani (2022-04-18 17:22:19)
> > > On Apr 18 17:04, Stephen Boyd wrote:
> > > > + retval = mfd_add_hotplug_devices(ec->dev,
> > > > + cros_ec_pchg_cells,
> > > > + ARRAY_SIZE(cros_ec_pchg_cells));
> > > > + if (retval)
> > > > + dev_warn(ec->dev, "failed to add pchg: %d\n",
> > > > + retval);
> > > Tiny nit: Can this fit in 1 line (100 chars[1])?
> > >
> >
> > I'm matching the style of other lines in this file (this is copy
> > pasta). I'll let the maintainer decide what to do.
>
> Quite a bit of that code predates the char limit update, but OK.