From: Greg KH <gregkh@linuxfoundation.org>
To: Mukesh Ojha <quic_mojha@quicinc.com>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
sboyd@kernel.org, rafael@kernel.org, johannes@sipsolutions.net,
keescook@chromium.org
Subject: Re: [PATCH v3] devcoredump : Serialize devcd_del work
Date: Tue, 26 Apr 2022 16:13:26 +0200 [thread overview]
Message-ID: <Ymf+Brpl77kvN1I4@kroah.com> (raw)
In-Reply-To: <1650981343-11739-1-git-send-email-quic_mojha@quicinc.com>
On Tue, Apr 26, 2022 at 07:25:43PM +0530, Mukesh Ojha wrote:
> + bool flg;
This is not the 1980's where we had a limited size for variable names
due to memory and compiler restrictions.
Please use vowels and descriptive names that identify what the variable
is for instantly. "flg" is unknown.
greg k-h
prev parent reply other threads:[~2022-04-26 14:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 13:55 [PATCH v3] devcoredump : Serialize devcd_del work Mukesh Ojha
2022-04-26 14:13 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymf+Brpl77kvN1I4@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johannes@sipsolutions.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_mojha@quicinc.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox