From: Greg KH <gregkh@linuxfoundation.org>
To: Tom Rix <trix@redhat.com>
Cc: jirislaby@kernel.org, nathan@kernel.org, ndesaulniers@google.com,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] tty: n_gsm: return -EINVAL when adaption is not supported
Date: Tue, 26 Apr 2022 20:37:42 +0200 [thread overview]
Message-ID: <Ymg79qM3Wq2rlYvj@kroah.com> (raw)
In-Reply-To: <4789ae7a-64a2-566b-d445-b8433d3f867a@redhat.com>
On Tue, Apr 26, 2022 at 11:16:35AM -0700, Tom Rix wrote:
>
> On 4/26/22 5:12 AM, Greg KH wrote:
> > On Tue, Apr 26, 2022 at 08:05:54AM -0400, Tom Rix wrote:
> > > The clang build fails with
> > > n_gsm.c:940:13: error: variable 'size' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
> > > } else if (dlci->adaption == 2) {
> > > ^~~~~~~~~~~~~~~~~~~
> > >
> > > The else should return an error, so return -EINVAL.
> > >
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> > What commit id does this fix? Any reason you didn't cc: the author of
> > the recent changes to this code?
> Sorry missed this part.
Please always do that, otherwise it's hard to track, right?
> > Is this the same issue that 0-day reported?
>
> Maybe, it was part of next's update today. Where is 0-day reported ?
On the same mailing list you posted this patch to:
https://lore.kernel.org/r/202204230704.5MxboEEo-lkp@intel.com
thanks,
greg k-h
prev parent reply other threads:[~2022-04-26 18:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 12:05 [PATCH] tty: n_gsm: return -EINVAL when adaption is not supported Tom Rix
2022-04-26 12:12 ` Greg KH
2022-04-26 18:16 ` Tom Rix
2022-04-26 18:37 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ymg79qM3Wq2rlYvj@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox