From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
Date: Tue, 26 Apr 2022 09:22:55 -0500 [thread overview]
Message-ID: <YmgAP5yrHWJESq8N@robh.at.kernel.org> (raw)
In-Reply-To: <469d7ac0-7cf6-af91-7e24-1d9df88c9221@linaro.org>
On Sat, Apr 23, 2022 at 08:44:21PM +0200, Krzysztof Kozlowski wrote:
> On 22/04/2022 21:23, Rob Herring wrote:
> > The samsung,s524ad0xd1 compatible is in use, but not documented. According
> > to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> > with the 24c128.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
>
> The compatible - without 24c128 fallback - is used also in
> arch/arm/boot/dts/exynos5250-smdk5250.dts and
> Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml, so these
> files should be fixed as well.
The dts file I was aware of and I leave that to the Exynos
maintainers/users. :)
For some reason samsung,s3c2410-i2c.yaml is not getting a warning. I'll
have to investigate.
Rob
prev parent reply other threads:[~2022-04-26 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 19:23 [PATCH] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible Rob Herring
2022-04-23 18:44 ` Krzysztof Kozlowski
2022-04-26 14:22 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmgAP5yrHWJESq8N@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bgolaszewski@baylibre.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox