* [PATCH] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
@ 2022-04-22 19:23 Rob Herring
2022-04-23 18:44 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2022-04-22 19:23 UTC (permalink / raw)
To: Bartosz Golaszewski, Krzysztof Kozlowski
Cc: Bartosz Golaszewski, linux-i2c, devicetree, linux-kernel
The samsung,s524ad0xd1 compatible is in use, but not documented. According
to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
with the 24c128.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/eeprom/at24.yaml b/Documentation/devicetree/bindings/eeprom/at24.yaml
index 6b61a8cf6137..d14e0accbda8 100644
--- a/Documentation/devicetree/bindings/eeprom/at24.yaml
+++ b/Documentation/devicetree/bindings/eeprom/at24.yaml
@@ -120,7 +120,9 @@ properties:
- const: giantec,gt24c32a
- const: atmel,24c32
- items:
- - const: renesas,r1ex24128
+ - enum:
+ - renesas,r1ex24128
+ - samsung,s524ad0xd1
- const: atmel,24c128
label:
--
2.32.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
2022-04-22 19:23 [PATCH] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible Rob Herring
@ 2022-04-23 18:44 ` Krzysztof Kozlowski
2022-04-26 14:22 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-23 18:44 UTC (permalink / raw)
To: Rob Herring, Bartosz Golaszewski, Krzysztof Kozlowski
Cc: Bartosz Golaszewski, linux-i2c, devicetree, linux-kernel
On 22/04/2022 21:23, Rob Herring wrote:
> The samsung,s524ad0xd1 compatible is in use, but not documented. According
> to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> with the 24c128.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
The compatible - without 24c128 fallback - is used also in
arch/arm/boot/dts/exynos5250-smdk5250.dts and
Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml, so these
files should be fixed as well.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible
2022-04-23 18:44 ` Krzysztof Kozlowski
@ 2022-04-26 14:22 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2022-04-26 14:22 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Bartosz Golaszewski, Krzysztof Kozlowski, Bartosz Golaszewski,
linux-i2c, devicetree, linux-kernel
On Sat, Apr 23, 2022 at 08:44:21PM +0200, Krzysztof Kozlowski wrote:
> On 22/04/2022 21:23, Rob Herring wrote:
> > The samsung,s524ad0xd1 compatible is in use, but not documented. According
> > to arch/arm/mach-s3c/mach-smdk6410.c, the samsung,s524ad0xd1 is compatible
> > with the 24c128.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/eeprom/at24.yaml | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
>
> The compatible - without 24c128 fallback - is used also in
> arch/arm/boot/dts/exynos5250-smdk5250.dts and
> Documentation/devicetree/bindings/i2c/samsung,s3c2410-i2c.yaml, so these
> files should be fixed as well.
The dts file I was aware of and I leave that to the Exynos
maintainers/users. :)
For some reason samsung,s3c2410-i2c.yaml is not getting a warning. I'll
have to investigate.
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-26 14:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-22 19:23 [PATCH] dt-bindings: eeprom/at24: Add samsung,s524ad0xd1 compatible Rob Herring
2022-04-23 18:44 ` Krzysztof Kozlowski
2022-04-26 14:22 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox