From: Lee Jones <lee.jones@linaro.org>
To: Cixi Geng <gengcixi@gmail.com>
Cc: orsonzhai@gmail.com, baolin.wang7@gmail.com,
zhang.lyra@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table
Date: Tue, 26 Apr 2022 15:44:44 +0100 [thread overview]
Message-ID: <YmgFXLAGDlQe4LZ4@google.com> (raw)
In-Reply-To: <20220425132410.2708304-1-gengcixi@gmail.com>
On Mon, 25 Apr 2022, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@unisoc.com>
>
> Add the SC2730 PMIC support for module autoloading
> through SPI modalises.
>
> Signed-off-by: Cixi Geng <cixi.geng1@unisoc.com>
> ---
> drivers/mfd/sprd-sc27xx-spi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/sprd-sc27xx-spi.c b/drivers/mfd/sprd-sc27xx-spi.c
> index 55d2c31bdfb2..cf4f89114ae4 100644
> --- a/drivers/mfd/sprd-sc27xx-spi.c
> +++ b/drivers/mfd/sprd-sc27xx-spi.c
> @@ -248,6 +248,7 @@ MODULE_DEVICE_TABLE(of, sprd_pmic_match);
>
> static const struct spi_device_id sprd_pmic_spi_ids[] = {
> { .name = "sc2731", .driver_data = (unsigned long)&sc2731_data },
> + { .name = "sc2730", .driver_data = (unsigned long)&sc2730_data },
Nicer if these were ordered with the smallest number at the top.
> {},
> };
> MODULE_DEVICE_TABLE(spi, sprd_pmic_spi_ids);
--
Lee Jones [李琼斯]
Principal Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2022-04-26 14:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-25 13:24 [PATCH] mfd: sprd: Add SC2730 PMIC to SPI device ID table Cixi Geng
2022-04-26 14:44 ` Lee Jones [this message]
2022-04-27 1:23 ` Cixi Geng
2022-04-27 7:37 ` Lee Jones
2022-04-27 7:53 ` Cixi Geng
2022-04-27 7:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmgFXLAGDlQe4LZ4@google.com \
--to=lee.jones@linaro.org \
--cc=baolin.wang7@gmail.com \
--cc=gengcixi@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox