From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Alexey Romanov <avromanov@sberdevices.ru>
Cc: minchan@kernel.org, ngupta@vflare.org, senozhatsky@chromium.org,
linux-block@vger.kernel.org, axboe@chromium.org,
kernel@sberdevices.ru, linux-kernel@vger.kernel.org,
mnitenko@gmail.com, Dmitry Rokosov <ddrokosov@sberdevices.ru>
Subject: Re: [PATCH v2] zram: remove double compression logic
Date: Wed, 27 Apr 2022 20:30:16 +0900 [thread overview]
Message-ID: <YmkpSC/gJf7Cg2Ym@google.com> (raw)
In-Reply-To: <20220427100345.29461-1-avromanov@sberdevices.ru>
On (22/04/27 13:03), Alexey Romanov wrote:
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index cb253d80d72b..4be6caf43b1d 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1153,9 +1153,8 @@ static ssize_t debug_stat_show(struct device *dev,
>
> down_read(&zram->init_lock);
> ret = scnprintf(buf, PAGE_SIZE,
> - "version: %d\n%8llu %8llu\n",
> + "version: %d\n%8llu\n",
> version,
> - (u64)atomic64_read(&zram->stats.writestall),
> (u64)atomic64_read(&zram->stats.miss_free));
> up_read(&zram->init_lock);
I think this also has to bump `version` to 2, since format of the
file has changed.
next prev parent reply other threads:[~2022-04-27 11:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 10:03 [PATCH v2] zram: remove double compression logic Alexey Romanov
2022-04-27 11:30 ` Sergey Senozhatsky [this message]
2022-04-28 20:01 ` Aleksey Romanov
2022-05-02 18:11 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmkpSC/gJf7Cg2Ym@google.com \
--to=senozhatsky@chromium.org \
--cc=avromanov@sberdevices.ru \
--cc=axboe@chromium.org \
--cc=ddrokosov@sberdevices.ru \
--cc=kernel@sberdevices.ru \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minchan@kernel.org \
--cc=mnitenko@gmail.com \
--cc=ngupta@vflare.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox