public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
Cc: arnd@arndb.de, catalin.marinas@arm.com, rostedt@goodmis.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	maz@kernel.org, quic_psodagud@quicinc.com,
	quic_tsoni@quicinc.com, will@kernel.org
Subject: Re: [PATCHv11 6/6] asm-generic/io: Add logging support for MMIO accessors
Date: Thu, 28 Apr 2022 07:53:04 +0200	[thread overview]
Message-ID: <YmorwEGw/SATMUKt@kroah.com> (raw)
In-Reply-To: <3de35c9f4a3a070d197bab499acefc709a6f5336.1645772606.git.quic_saipraka@quicinc.com>

On Thu, Apr 28, 2022 at 09:00:13AM +0530, Sai Prakash Ranjan wrote:
> Add logging support for MMIO high level accessors such as read{b,w,l,q}
> and their relaxed versions to aid in debugging unexpected crashes/hangs
> caused by the corresponding MMIO operation. Also add a generic flag
> (__DISABLE_TRACE_MMIO__) which is used to disable MMIO tracing in nVHE KVM
> and if required can be used to disable MMIO tracing for specific drivers.

Also, this should be split up into 2 patches, one to add the "disable
the feature" flag, and one to enable it for the specific driver(s) you
want.

Hint, when you say "also" in a changelog text, that's a huge sign that
it perhaps should be split up into smaller pieces.

thanks,

greg k-h

  parent reply	other threads:[~2022-04-28  5:53 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-28  3:30 [PATCHv11 0/6] lib/rwmmio/arm64: Add support to trace register reads/writes Sai Prakash Ranjan
2022-04-28  3:30 ` [PATCHv11 1/6] arm64: io: Use asm-generic high level MMIO accessors Sai Prakash Ranjan
2022-04-28  3:30 ` [PATCHv11 2/6] coresight: etm4x: Use asm-generic IO memory barriers Sai Prakash Ranjan
2022-04-28  3:30 ` [PATCHv11 3/6] irqchip/tegra: Fix overflow implicit truncation warnings Sai Prakash Ranjan
2022-04-28  3:30 ` [PATCHv11 4/6] drm/meson: " Sai Prakash Ranjan
2022-04-28  3:30 ` [PATCHv11 5/6] lib: Add register read/write tracing support Sai Prakash Ranjan
2022-04-28  3:30 ` [PATCHv11 6/6] asm-generic/io: Add logging support for MMIO accessors Sai Prakash Ranjan
2022-04-28  5:51   ` Greg KH
2022-04-28  7:29     ` Sai Prakash Ranjan
2022-04-28  7:35       ` Greg KH
2022-04-28  7:44         ` Sai Prakash Ranjan
2022-04-28  8:20           ` Greg KH
2022-04-28  8:18         ` Arnd Bergmann
2022-04-28  8:24           ` Greg KH
2022-04-28  5:53   ` Greg KH [this message]
2022-04-28  7:32     ` Sai Prakash Ranjan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YmorwEGw/SATMUKt@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=quic_psodagud@quicinc.com \
    --cc=quic_saipraka@quicinc.com \
    --cc=quic_tsoni@quicinc.com \
    --cc=rostedt@goodmis.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox