From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 167A6C4332F for ; Thu, 28 Apr 2022 16:15:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349853AbiD1QTB (ORCPT ); Thu, 28 Apr 2022 12:19:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349898AbiD1QS7 (ORCPT ); Thu, 28 Apr 2022 12:18:59 -0400 Received: from mail-pg1-x52d.google.com (mail-pg1-x52d.google.com [IPv6:2607:f8b0:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 62FD629815 for ; Thu, 28 Apr 2022 09:15:43 -0700 (PDT) Received: by mail-pg1-x52d.google.com with SMTP id z21so4380777pgj.1 for ; Thu, 28 Apr 2022 09:15:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Dfa1bV+l0rTD/48Pn9eH0bLjlOwV1+aYl2ofQSrXJUM=; b=hWZiuHu8JdkaW16COERrDY5bK6U72h+rWDMYgBl2WsnIVOQwa3cmfWdmXW3QL4ho3D GmDWhfJ6qhqQrHlZlJGNhkQ4RDqj4dHbwdCIPbADdhn/LLzhC7ZiLboE0eHKGeypFLv4 cReOdJ48psk9nQNdUBp8jsYfW60zM2w7XKXMk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Dfa1bV+l0rTD/48Pn9eH0bLjlOwV1+aYl2ofQSrXJUM=; b=tHxVo0wERqg9+XK1qlMg9dlIbrZfQfa2qEeIPKdKdrI/ONInw4cItoND/L2MS0XKph nKB1CmaC0qoSoztok/lEUO0fl/lXbkVQLXvUityqUtM3V/50GRM5UQCokmOWsX5xh3y8 lzbrQG9NEmJ/kGSPYUnRfLBFbh7Av+poJl2UGFsXjcBDXWr4qOTsGt8cdlbCs8gutMRs CeOUlAlN3q8zbCGL8lqcnesaG252honBF6ilnSjwJo1lcgzasF+0DYvo6CnkB4ynNoQZ VmhV8mzdMgCdqTtoUMHmnqlQcxJNfE1AW0RMumBlU9hbKfA9K8G+Gi6SsXrUoifBmv0S 6VXw== X-Gm-Message-State: AOAM530R8Ozh6Zp5ZwL4yP4kbACaMjAvRbw9n+oGwdBi5aKWbzWqZRmU T66HJD7pBWkhgBBMvwVd+iYlxQ== X-Google-Smtp-Source: ABdhPJzlBNQOMivdc1V03Wr32p3jvOOeJtUJvOQ9TbIPp9SCu1XaxHBr07iH7lOg3BRvs0j4aFP0wQ== X-Received: by 2002:aa7:83c2:0:b0:505:723f:6ace with SMTP id j2-20020aa783c2000000b00505723f6acemr35965537pfn.86.1651162542894; Thu, 28 Apr 2022 09:15:42 -0700 (PDT) Received: from localhost ([2620:15c:202:201:7a56:fc44:2682:8a2e]) by smtp.gmail.com with UTF8SMTPSA id 132-20020a62168a000000b004f40e8b3133sm293538pfw.188.2022.04.28.09.15.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 09:15:42 -0700 (PDT) Date: Thu, 28 Apr 2022 09:15:39 -0700 From: Matthias Kaehlcke To: Doug Anderson Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Stephen Boyd Subject: Re: [PATCH v22 1/2] arm64: dts: qcom: sc7180-trogdor: Add nodes for onboard USB hub Message-ID: References: <20220426170306.v22.1.I7a1a6448d50bdd38e6082204a9818c59cc7a9bfd@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 27, 2022 at 02:05:04PM -0700, Doug Anderson wrote: > Hi, > > On Tue, Apr 26, 2022 at 5:03 PM Matthias Kaehlcke wrote: > > > > Add nodes for the onboard USB hub on trogdor devices. Remove the > > 'always-on' property from the hub regulator, since the regulator > > is now managed by the onboard_usb_hub driver. > > There are people out there that are running trogdor devices with > upstream Linux. There's not much we can do about it, but probably this > patch will cause them to fail to probe USB because they won't have > "CONFIG_USB_ONBOARD_HUB=y". Luckily the commit subject has "USB" in it > so hopefully it'll be easy to spot, but I wonder if we should add > something to the commit message that makes that super obvious and > tells them about the relevant commit, like: > > For anyone using trogdor-based devices on Linux, it should be noted > that this requires "CONFIG_USB_ONBOARD_HUB=y". Ok, I'll respin and add the note. > > Signed-off-by: Matthias Kaehlcke > > Reviewed-by: Stephen Boyd > > Reviewed-by: Douglas Anderson > > --- > > Depends on "usb: misc: Add onboard_usb_hub driver" [1] which landed in > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/?h=usb-testing > > > > This patch was split off the above series. > > > > [1] https://patchwork.kernel.org/project/linux-usb/list/?series=615531&state=%2A&archive=both > > I presume it will be moderately annoying if this lands in the Qualcomm > branch before the driver lands in mainline? Otherwise USB will fully > stop working on the Qualcomm branch. Do we want to postpone landing > this? Postponing the trogdor patch sounds good to me.