[PATCH -next] vt: defkeymap.c_shipped remove unused variables

[PATCH -next] vt: defkeymap.c_shipped remove unused variables

[Zhang Jianhua]

The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
been initialized but not used, they are redundant and remove them.

--------

Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
---
 drivers/tty/vt/defkeymap.c_shipped | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/tty/vt/defkeymap.c_shipped b/drivers/tty/vt/defkeymap.c_shipped
index 094d95bf0005..80dee50bcb7a 100644
--- a/drivers/tty/vt/defkeymap.c_shipped
+++ b/drivers/tty/vt/defkeymap.c_shipped
@@ -185,10 +185,6 @@ char func_buf[] = {
 	'\033', '[', 'P', 0, 
 };
 
-char *funcbufptr = func_buf;
-int funcbufsize = sizeof(func_buf);
-int funcbufleft = 0;          /* space left */
-
 char *func_table[MAX_NR_FUNC] = {
 	func_buf + 0,
 	func_buf + 5,
-- 
2.31.0

Re: [PATCH -next] vt: defkeymap.c_shipped remove unused variables

[Greg KH]

On Fri, Apr 29, 2022 at 09:48:14AM +0800, Zhang Jianhua wrote:
> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
> been initialized but not used, they are redundant and remove them.
> 
> --------

Why this extra "------" line?

> 
> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
> ---
>  drivers/tty/vt/defkeymap.c_shipped | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/tty/vt/defkeymap.c_shipped b/drivers/tty/vt/defkeymap.c_shipped
> index 094d95bf0005..80dee50bcb7a 100644
> --- a/drivers/tty/vt/defkeymap.c_shipped
> +++ b/drivers/tty/vt/defkeymap.c_shipped
> @@ -185,10 +185,6 @@ char func_buf[] = {
>  	'\033', '[', 'P', 0, 
>  };
>  
> -char *funcbufptr = func_buf;
> -int funcbufsize = sizeof(func_buf);
> -int funcbufleft = 0;          /* space left */
> -
>  char *func_table[MAX_NR_FUNC] = {
>  	func_buf + 0,
>  	func_buf + 5,
> -- 
> 2.31.0
> 

Shouldn't you fix up the loadkeys tool instead?  As the top of this file
says, it is auto-generated and is not something to be hand-edited at
all.

thanks,

greg k-h

Re: [PATCH -next] vt: defkeymap.c_shipped remove unused variables

[zhangjianhua (E)]

在 2022/4/29 14:39, Greg KH 写道:
> On Fri, Apr 29, 2022 at 09:48:14AM +0800, Zhang Jianhua wrote:
>> The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
>> been initialized but not used, they are redundant and remove them.
>>
>> --------
> Why this extra "------" line?

This line "------" means the end of commit message, if it is redundant, I will remove it in next version.

>> Signed-off-by: Zhang Jianhua <chris.zjh@huawei.com>
>> ---
>>   drivers/tty/vt/defkeymap.c_shipped | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/tty/vt/defkeymap.c_shipped b/drivers/tty/vt/defkeymap.c_shipped
>> index 094d95bf0005..80dee50bcb7a 100644
>> --- a/drivers/tty/vt/defkeymap.c_shipped
>> +++ b/drivers/tty/vt/defkeymap.c_shipped
>> @@ -185,10 +185,6 @@ char func_buf[] = {
>>   	'\033', '[', 'P', 0,
>>   };
>>   
>> -char *funcbufptr = func_buf;
>> -int funcbufsize = sizeof(func_buf);
>> -int funcbufleft = 0;          /* space left */
>> -
>>   char *func_table[MAX_NR_FUNC] = {
>>   	func_buf + 0,
>>   	func_buf + 5,
>> -- 
>> 2.31.0
>>
> Shouldn't you fix up the loadkeys tool instead?  As the top of this file
> says, it is auto-generated and is not something to be hand-edited at
> all.
>
> thanks,
>
> greg k-h
> .
Thanks, I will read the source code more carefully, and fix up the 
loadkeys tool if it is indeed a problem.

Re: [PATCH -next] vt: defkeymap.c_shipped remove unused variables

[Greg KH]

On Thu, May 05, 2022 at 11:10:55AM +0800, zhangjianhua (E) wrote:
> 
> 在 2022/4/29 14:39, Greg KH 写道:
> > On Fri, Apr 29, 2022 at 09:48:14AM +0800, Zhang Jianhua wrote:
> > > The global variables 'funcbufptr' 'funcbufsize' and 'funcbufleft' have
> > > been initialized but not used, they are redundant and remove them.
> > > 
> > > --------
> > Why this extra "------" line?
> 
> This line "------" means the end of commit message, if it is redundant, I will remove it in next version.

That is not used in kernel changelogs at all, sorry.  Please don't add
it in future changes either.

thanks,

greg k-h