From: Peter Zijlstra <peterz@infradead.org>
To: x86@kernel.org, jpoimboe@redhat.com
Cc: linux-kernel@vger.kernel.org, Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH] objtool: Fix STACK_FRAME_NON_STANDARD reloc type
Date: Fri, 29 Apr 2022 14:00:44 +0200 [thread overview]
Message-ID: <YmvTbN966XmLSZk+@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20220429092024.GT2731@worktop.programming.kicks-ass.net>
On Fri, Apr 29, 2022 at 11:20:24AM +0200, Peter Zijlstra wrote:
>
> STACK_FRAME_NON_STANDARD results in inconsistent relocation types
> depending on .c or .S usage:
>
> Relocation section '.rela.discard.func_stack_frame_non_standard' at offset 0x3c01090 contains 5 entries:
> Offset Info Type Symbol's Value Symbol's Name + Addend
> 0000000000000000 00020c2200000002 R_X86_64_PC32 0000000000047b40 do_suspend_lowlevel + 0
> 0000000000000008 0002461e00000001 R_X86_64_64 00000000000480a0 machine_real_restart + 0
> 0000000000000010 0000001400000001 R_X86_64_64 0000000000000000 .rodata + b3d4
> 0000000000000018 0002444600000002 R_X86_64_PC32 00000000000678a0 __efi64_thunk + 0
> 0000000000000020 0002659d00000001 R_X86_64_64 0000000000113160 __crash_kexec + 0
So that weird .rodata entry is optprobe_template_func.
It being in .rodata also means it's not validated and there is no ORC
data generated, is that all intentional? The changelog for:
877b145f0f47 ("x86/kprobes: Move trampoline code into RODATA")
doesn't really say anything useful about any of that :/
I also don't see any kprobe/optprobe hooks in unwind.h, so what happens
if we hit an optprobe?
next prev parent reply other threads:[~2022-04-29 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 9:20 [PATCH] objtool: Fix STACK_FRAME_NON_STANDARD reloc type Peter Zijlstra
2022-04-29 12:00 ` Peter Zijlstra [this message]
2022-04-29 22:56 ` Josh Poimboeuf
2022-04-30 11:44 ` Peter Zijlstra
2022-05-02 17:59 ` Josh Poimboeuf
2022-05-04 15:42 ` Masami Hiramatsu
2022-05-04 15:23 ` Masami Hiramatsu
2022-04-29 20:13 ` Josh Poimboeuf
2022-04-29 21:22 ` [PATCH v2] " Peter Zijlstra
2022-04-29 21:53 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YmvTbN966XmLSZk+@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox